| commit | 347cc4ba259a8fb46f9bc22341a3574e2ba72e6a | [log] [tgz] |
|---|---|---|
| author | Halil Ozercan <[email protected]> | Wed Jan 03 13:55:46 2024 +0000 |
| committer | Android Build Coastguard Worker <[email protected]> | Mon Jan 15 20:07:35 2024 +0000 |
| tree | 924ca6857bd8cc509b6fc62ef8bff76e35087773 | |
| parent | 19acbe7904f94fa562ea9ef4c186f34add08a6ae [diff] |
Remove root view focus check when executing keyboard commands Background; A while ago a focus check was added to `processInputCommands` to skip executing commands at the end of the frame if the owner view has already lost its focus. This was addressing a problem where a focus switch from a TextField to EditText would cause Keyboard to flicker. Problem; A new change to the Compose Focus system now correctly releases the focus from Compose owner view when there are no longer focused Composables in its control. However, this invalidates `TextInputServiceAndroid#processInputCommands`'s assumption that Compose owner view would always have focus unless it's transferred to another Android view. Disposing a TextField, or clearing focus from a TextField, no longer hides the keyboard which is a serious problem. This CL fixes this problem by removing the previously added focus check. Note; THIS BRINGS BACK THE INTEROP BUG. This CL unfortunately would bring back the keyboard problem when interacting between TextField and EditText. However due to the much higher priority of the original bug that's addressed in this CL, we will leave solving this re-introduced bug as a future work. Bug: 318424446 Bug: 313375840 Test: :compose:foundation:foundation:cAT (cherry picked from https://android-review.googlesource.com/q/commit:cda8f0ebcfcd9833751097b06b6938134b147036) (cherry picked from https://android-review.googlesource.com/q/commit:0e3eaa27eeeac8a73f44653ba8c4c3c1a5969ce8) Merged-In: Ibc5dc78927d75c8220a62587e9ce8325929585ba Change-Id: Ibc5dc78927d75c8220a62587e9ce8325929585ba
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.