Google Git
Sign in
android / platform / frameworks / support / 8c0438b4bdcf0f9ca6003c5d91f452c1f371691a
commit8c0438b4bdcf0f9ca6003c5d91f452c1f371691a[log] [tgz]
authorrohitsat13 <[email protected]>Thu Jan 14 13:47:39 2021 -0800
committerRohit Sathyanarayana <[email protected]>Fri Jan 22 17:44:58 2021 +0000
treefe9dd7e51436a153031c7af560b4a74509f22c06
parenta8fabff5f9e0d2ec9a335d861c5e453455dc2d4b [diff]
Fix Cancellation behavior when caller scope is cancelled.

Currently our updates wait datastore's scope until they are completed. This means that only the datastore's scope propagates cancellation to the update. If the caller's scope is cancelled, it doesn't propagate until their update actually runs which means cancellation can take much longer than it should.

I tried to use the Channel(onUndeliveredElement) callback but it's broken for UNLIMITED size channels right now so I just implemented a naive version of it myself.

Bug: N/A
Relnote: Fix cancellation behavior when caller scope is cancelled.
Test: See new datastore tests.
Change-Id: I2c7b335c01cc2b59bea4474d676c4343ec90e596
4 files changed
tree: fe9dd7e51436a153031c7af560b4a74509f22c06
  1. .github/
  2. .idea/
  3. activity/
  4. ads/
  5. androidx-plugin/
  6. annotation/
  7. appcompat/
  8. appsearch/
  9. arch/
  10. asynclayoutinflater/
  11. autofill/
  12. benchmark/
  13. biometric/
  14. browser/
  15. buildSrc/
  16. buildSrc-tests/
  17. busytown/
  18. camera/
  19. car/
  20. cardview/
  21. collection/
  22. compose/
  23. concurrent/
  24. contentaccess/
  25. contentpager/
  26. coordinatorlayout/
  27. core/
  28. cursoradapter/
  29. customview/
  30. datastore/
  31. development/
  32. docs/
  33. docs-public/
  34. docs-tip-of-tree/
  35. documentfile/
  36. drawerlayout/
  37. dynamic-animation/
  38. emoji/
  39. enterprise/
  40. exifinterface/
  41. fakeannotations/
  42. fragment/
  43. frameworks/
  44. gradle/
  45. gridlayout/
  46. heifwriter/
  47. hilt/
  48. inspection/
  49. interpolator/
  50. ipc/
  51. jetifier/
  52. leanback/
  53. legacy/
  54. lifecycle/
  55. lint-checks/
  56. lint-demos/
  57. loader/
  58. localbroadcastmanager/
  59. media/
  60. media2/
  61. mediarouter/
  62. mppsample/
  63. navigation/
  64. paging/
  65. palette/
  66. percentlayout/
  67. placeholder-tests/
  68. playground/
  69. playground-common/
  70. preference/
  71. print/
  72. recommendation/
  73. recyclerview/
  74. remotecallback/
  75. resourceinspection/
  76. room/
  77. samples/
  78. savedstate/
  79. security/
  80. serialization/
  81. sharetarget/
  82. slices/
  83. slidingpanelayout/
  84. sqlite/
  85. startup/
  86. swiperefreshlayout/
  87. test/
  88. testutils/
  89. text/
  90. textclassifier/
  91. tracing/
  92. transition/
  93. tv-provider/
  94. ui/
  95. vectordrawable/
  96. versionedparcelable/
  97. viewpager/
  98. viewpager2/
  99. wear/
  100. webkit/
  101. window/
  102. work/
  103. .gitignore
  104. .mailmap
  105. build.gradle
  106. cleanBuild.sh
  107. code-review.md
  108. CONTRIBUTING.md
  109. gradle.properties
  110. gradlew
  111. include-composite-deps.gradle
  112. include-support-library.gradle
  113. LICENSE.txt
  114. OWNERS
  115. PREUPLOAD.cfg
  116. README.md
  117. settings.gradle
  118. studiow
README.md

Android Jetpack

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

  1. Install repo (Repo is a tool that makes it easier to work with Git in the context of Android. For more information about Repo, see the Repo Command Reference)
mkdir ~/bin
PATH=~/bin:$PATH
curl https://storage.googleapis.com/git-repo-downloads/repo > ~/bin/repo
chmod a+x ~/bin/repo
  1. Configure Git with your real name and email address.
git config --global user.name "Your Name"
git config --global user.email "[email protected]"
  1. Create a directory for your checkout (it can be any name)
mkdir androidx-main
cd androidx-main
  1. Use repo command to initialize the repository.
repo init -u https://android.googlesource.com/platform/manifest -b androidx-main --partial-clone --clone-filter=blob:limit=10M
  1. Now your repository is set to pull only what you need for building and running AndroidX libraries. Download the code (and grab a coffee while we pull down the files):
repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

To open the project with the specific version of Android Studio recommended for developing:

cd path/to/checkout/frameworks/support/
ANDROIDX_PROJECTS=MAIN ./gradlew studio

and accept the license agreement when prompted. Now you're ready to edit, run, and test!

You can also the following sets of projects: ALL, MAIN, COMPOSE, or FLAN

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full AndroidX library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Testing modified AndroidX Libraries to in your App

You can build maven artifacts locally, and test them directly in your app:

./gradlew createArchive

And put the following at the top of your ‘repositories’ property in your project build.gradle file:

maven { url '/path/to/checkout/out/androidx/build/support_repo/' }

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run androidx.foobar

Running Sample Apps

The AndroidX repository has a set of Android applications that exercise AndroidX code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named either <libraryname>-integration-tests-testapp, or support-\*-demos (e.g. support-v4-demos or support-leanback-demos). You can run them by clicking Run > Run ... and choosing the desired application.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
# make needed modifications...
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

If the upload succeeds, you'll see output like:

remote:
remote: New Changes:
remote:   https://android-review.googlesource.com/c/platform/frameworks/support/+/720062 Further README updates
remote:

To edit your change, use git commit --amend, and re-upload.

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.