| commit | a67b4b8bbcd4e56ff0a137ad4f4b1186d76cfbf9 | [log] [tgz] |
|---|---|---|
| author | Ralston Da Silva <[email protected]> | Fri Apr 07 13:52:52 2023 -0700 |
| committer | Android Build Coastguard Worker <[email protected]> | Tue Apr 25 22:14:43 2023 +0000 |
| tree | 881a754af14162ba11d765cce132473470c82e02 | |
| parent | d26bef8008a491d130383a911e490bb4a45ac3b0 [diff] |
Fix Regression in custom enter/exit focus properties We use a fetchCustomEnter function that has some logic to prevent the lambda from being re-entrant when focus is redirected to a portion of the hierarchy that already executed the enter/exit block. When a return statement is placed in an anonymous lambda, it short-circuits to return from the entire function, not from the lambda. In this case it skipped over some cleanup logic isProcessingCustomEnter = false inside the intermediate inline function, so this led to a nonobvious bug. Added a try-finally block to fix this issue and ensure that the cleanup logic is always run. Fixes: 277234245 Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.RequestFocusEnterTest Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.RequestFocusExitTest (cherry picked from https://android-review.googlesource.com/q/commit:7a047f17c835a7a0ef63105fad3661060310cf9b) (cherry picked from https://android-review.googlesource.com/q/commit:ebb720c9d3627da53a6658c808de384f2eeaa0a3) Merged-In: I7715190081686b2b01010b35375633cfc1c6ca3b Change-Id: I7715190081686b2b01010b35375633cfc1c6ca3b
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.