Google Git
Sign in
android / platform / frameworks / support / cacdbcfc67d700868e115a0ed7a78df2b1aed38d
commitcacdbcfc67d700868e115a0ed7a78df2b1aed38d[log] [tgz]
authorViktor Yakovel <[email protected]>Wed Mar 26 08:36:49 2025 +0000
committerViktor Yakovel <[email protected]>Fri Apr 11 11:25:19 2025 +0000
treed8b0635672b0b77564051293b4b2c5da1224587d
parent4d469332cea268911e62bcf9f6243b2a763bce09 [diff]
Do not recreate path on every draw in BackgroundPainter

Performance increase isn't obvious from the benchmark testing, but this change reduces amount of garbage Paths together with their native part clean ups

TransformingLazyColumnNotificationsBenchmarkTest benchark:

* Before
TransformingLazyColumnNotificationsBenchmarkTest_start[compilation=BaselineProfile]
gfxFrameJankPercent            min       0.7,   median       0.7,   max       1.4
gfxFrameTime50thPercentileMs   min      11.0,   median      11.0,   max      22.0
gfxFrameTime90thPercentileMs   min      16.0,   median      18.0,   max      30.0
gfxFrameTime95thPercentileMs   min      19.0,   median      25.0,   max      40.0
gfxFrameTime99thPercentileMs   min      26.0,   median      32.0,   max      48.0
gfxFrameTotalCount             min     140.0,   median     144.5,   max     166.0
memoryHeapSizeLastKb           min   4,470.0,   median   9,259.0,   max  17,792.0
memoryRssAnonLastKb            min  55,296.0,   median  60,672.0,   max  70,144.0
memoryRssFileLastKb            min 102,400.0,   median 103,928.0,   max 104,920.0

* After
TransformingLazyColumnNotificationsBenchmarkTest_start[compilation=BaselineProfile]
gfxFrameJankPercent            min       0.6,   median       0.7,   max       0.7
gfxFrameTime50thPercentileMs   min      11.0,   median      11.0,   max      21.0
gfxFrameTime90thPercentileMs   min      16.0,   median      18.0,   max      32.0
gfxFrameTime95thPercentileMs   min      21.0,   median      25.0,   max      36.0
gfxFrameTime99thPercentileMs   min      26.0,   median      30.0,   max      48.0
gfxFrameTotalCount             min     140.0,   median     143.0,   max     162.0
memoryHeapSizeLastKb           min   4,450.0,   median   9,191.0,   max  17,676.0
memoryRssAnonLastKb            min  55,296.0,   median  60,688.0,   max  70,144.0
memoryRssFileLastKb            min 102,912.0,   median 103,898.0,   max 104,704.0

Bug: 376693576
Relnote: N/A
Test: manual vefirication in AHAT to see decreased number of Path objects
Change-Id: Ie011e0e54852bb0ab43bd9f85e1e4cde5884c1a8
1 file changed
tree: d8b0635672b0b77564051293b4b2c5da1224587d
  1. .github/
  2. .idea/
  3. activity/
  4. annotation/
  5. appcompat/
  6. appfunctions/
  7. appintegration/
  8. appsearch/
  9. arch/
  10. asynclayoutinflater/
  11. autofill/
  12. benchmark/
  13. binarycompatibilityvalidator/
  14. biometric/
  15. browser/
  16. buildSrc/
  17. buildSrc-tests/
  18. busytown/
  19. camera/
  20. car/
  21. cardview/
  22. collection/
  23. compose/
  24. concurrent/
  25. constraintlayout/
  26. coordinatorlayout/
  27. core/
  28. credentials/
  29. cursoradapter/
  30. customview/
  31. datastore/
  32. development/
  33. docs/
  34. docs-public/
  35. docs-tip-of-tree/
  36. documentfile/
  37. draganddrop/
  38. drawerlayout/
  39. dynamicanimation/
  40. emoji/
  41. emoji2/
  42. enterprise/
  43. exifinterface/
  44. external/
  45. fragment/
  46. glance/
  47. gradle/
  48. graphics/
  49. gridlayout/
  50. health/
  51. heifwriter/
  52. hilt/
  53. ink/
  54. input/
  55. inspection/
  56. interpolator/
  57. javascriptengine/
  58. kruth/
  59. leanback/
  60. lifecycle/
  61. lint/
  62. lint-checks/
  63. loader/
  64. media/
  65. mediarouter/
  66. metrics/
  67. navigation/
  68. navigation3/
  69. paging/
  70. palette/
  71. pdf/
  72. percentlayout/
  73. performance/
  74. placeholder/
  75. placeholder-tests/
  76. playground-common/
  77. playground-projects/
  78. preference/
  79. print/
  80. privacysandbox/
  81. profileinstaller/
  82. recommendation/
  83. recyclerview/
  84. remotecallback/
  85. resourceinspection/
  86. room/
  87. safeparcel/
  88. samples/
  89. savedstate/
  90. security/
  91. sharetarget/
  92. slidingpanelayout/
  93. sqlite/
  94. stableaidl/
  95. startup/
  96. swiperefreshlayout/
  97. test/
  98. testutils/
  99. text/
  100. tracing/
  101. transition/
  102. tv/
  103. tvprovider/
  104. vectordrawable/
  105. versionedparcelable/
  106. viewpager/
  107. viewpager2/
  108. wear/
  109. webkit/
  110. window/
  111. work/
  112. xr/
  113. .gitignore
  114. build.gradle
  115. cleanBuild.sh
  116. code-review.md
  117. CONTRIBUTING.md
  118. gradle.properties
  119. gradlew
  120. libraryversions.toml
  121. license-baseline.txt
  122. LICENSE.txt
  123. OWNERS
  124. PREUPLOAD.cfg
  125. README.md
  126. settings.gradle
  127. studiow
  128. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Develocity

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.