Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/internal_auth_unittest.cc b/chrome/browser/internal_auth_unittest.cc
index 42080cd..da8954e 100644
--- a/chrome/browser/internal_auth_unittest.cc
+++ b/chrome/browser/internal_auth_unittest.cc
@@ -69,9 +69,10 @@
token, long_string_, map));
// Trying empty domain.
- token = InternalAuthGeneration::GeneratePassport("", map);
+ token = InternalAuthGeneration::GeneratePassport(std::string(), map);
ASSERT_TRUE(token.empty());
- ASSERT_FALSE(InternalAuthVerification::VerifyPassport(token, "", map));
+ ASSERT_FALSE(
+ InternalAuthVerification::VerifyPassport(token, std::string(), map));
std::string dummy("abcdefghij");
for (size_t i = 1000; i--;) {
@@ -87,7 +88,7 @@
ASSERT_FALSE(InternalAuthVerification::VerifyPassport(token, "zapata", map));
map.clear();
- map[""] = "value";
+ map[std::string()] = "value";
// Trying empty key.
token = InternalAuthGeneration::GeneratePassport("zapata", map);
ASSERT_TRUE(token.empty());
