commit | dc5d47c8ab0d958bdd967a834c472106f9697375 | [log] [tgz] |
---|---|---|
author | Dale Curtis <[email protected]> | Thu Feb 15 11:15:19 2018 |
committer | Commit Bot <[email protected]> | Thu Feb 15 11:15:19 2018 |
tree | 06f72462b34cd5e7435e1a9fcd15355cdad9e67a | |
parent | d8ec149f36aa29dfd19e44322d75f8598b730f30 [diff] |
Revert "Remove kHaveFutureData restriction from play state notifications." This reverts commit b0ec93f6f1c9dd4754c813f198336a7a4c2f22a4. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=812423 Original change's description: > Remove kHaveFutureData restriction from play state notifications. > > This reland marks media-src-suspend-after-have-future-data and > media-src-suspend-after-have-metadata as SlowTest(s) now that they no > longer permanently time out. Each takes ~2ish seconds in release build > and so meets the criteria for being a SlowTest. > > This also changes WMPI to not try and get the current time value prior > to the HaveCurrentData state (which Blink already respects). > > ========= [ Original Description Follows ] =============== > > HTMLMediaElement should tell WebMediaPlayer about play state changes > as soon as the kHaveMetaData state is reached. > > This will eventually allow us to delete a bunch of guessing-game type > code for idle suspension and instead rely on actually getting a play() > call from Blink to wake up when needed. > > We can't stop WMPI from reaching the future data state quite yet though, > because it has implications on the delivery of 'canplay' and 'canplaythrough' > events that need to be part of a larger preload=metadata experiment. See old > discussion on this here: > > https://lists.w3.org/Archives/Public/public-whatwg-archive/2015Jul/0007.html > > Note: This change exposed some bugs in how the ready state maximum is used > and the states at which a video frame is expected. These issues are fixed > in the HTMLVideoElement. > > BUG=694855, 756897, 809998 > TEST=existing suspend tests no longer flake. > > Change-Id: Ie6297df474c1f5da56ca6c0e81efa636fbc349bf > Reviewed-on: https://chromium-review.googlesource.com/915081 > Reviewed-by: Frank Liberato <[email protected]> > Reviewed-by: Mounir Lamouri <[email protected]> > Commit-Queue: Dale Curtis <[email protected]> > Cr-Commit-Position: refs/heads/master@{#536487} [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 694855, 756897, 809998 Change-Id: I176b5116682851853ff2773e6e4a77a9ac2664b2 Reviewed-on: https://chromium-review.googlesource.com/920481 Reviewed-by: Dale Curtis <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: Mounir Lamouri <[email protected]> Cr-Commit-Position: refs/heads/master@{#536988}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .