Rename WebContentsDelegate methods.
The WebContentsDelegate method IsPopupOrPanel() has a name
that is less than helpful. Panels were removed years ago and
aren't a web platform concept anyway, and the only thing
it gates is the ability of a WebContents to move/resize
itself.
This renames all the "move WebContents" calls to be "set bounds"
as that's what they're really used for. This renaming flows
quite far back through other delegates and IPC calls.
BUG=571511
Change-Id: I9938c171e03c33849ce1585d85bda5cfc93a7002
Reviewed-on: https://chromium-review.googlesource.com/1085427
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#565152}diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index adb1bc2..87aa4cc 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2655,7 +2655,7 @@
RenderWidgetHostImpl* rwh =
weak_popup->GetMainFrame()->GetRenderWidgetHost();
DCHECK_EQ(main_frame_widget_route_id, rwh->GetRoutingID());
- rwh->Send(new ViewMsg_Move_ACK(rwh->GetRoutingID()));
+ rwh->Send(new ViewMsg_SetBounds_ACK(rwh->GetRoutingID()));
}
}
@@ -5247,9 +5247,9 @@
delegate_->CloseContents(this);
}
-void WebContentsImpl::RequestMove(const gfx::Rect& new_bounds) {
- if (delegate_ && delegate_->IsPopupOrPanel(this))
- delegate_->MoveContents(this, new_bounds);
+void WebContentsImpl::RequestSetBounds(const gfx::Rect& new_bounds) {
+ if (delegate_)
+ delegate_->SetContentsBounds(this, new_bounds);
}
void WebContentsImpl::DidStartLoading(FrameTreeNode* frame_tree_node,
