Migrate NOTREACHED_NORETURN -> NOTREACHED
NOTREACHED() has turned [[noreturn]] so the former macro isn't needed
anymore.
This does not attempt to do a rewrite of any surrounding code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
NO_IFTTT=No-op-rename migration.
Bug: 40580068
Change-Id: I068c5fdce9dc4c352d8bdd62bb3cd2c0a2d59659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782602
Reviewed-by: Daniel Cheng <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1342096}
diff --git a/gin/v8_isolate_memory_dump_provider.cc b/gin/v8_isolate_memory_dump_provider.cc
index 7dcc2d4..e7690fe4 100644
--- a/gin/v8_isolate_memory_dump_provider.cc
+++ b/gin/v8_isolate_memory_dump_provider.cc
@@ -135,11 +135,11 @@
case IsolateHolder::IsolateType::kBlinkWorkerThread:
return "workers";
case IsolateHolder::IsolateType::kTest:
- NOTREACHED_NORETURN();
+ NOTREACHED();
case IsolateHolder::IsolateType::kUtility:
return "utility";
}
- NOTREACHED_NORETURN();
+ NOTREACHED();
}
bool CanHaveMultipleIsolates(IsolateHolder::IsolateType isolate_type) {
@@ -149,12 +149,12 @@
case IsolateHolder::IsolateType::kBlinkWorkerThread:
return true;
case IsolateHolder::IsolateType::kTest:
- NOTREACHED_NORETURN();
+ NOTREACHED();
case IsolateHolder::IsolateType::kUtility:
// PDFium and ProxyResolver create one isolate per process.
return false;
}
- NOTREACHED_NORETURN();
+ NOTREACHED();
}
} // namespace
