Google Git
Sign in
chromium / chromium / src.git / 03a986b720bf72110cc59094fadf1fe6bd1a700b
commit03a986b720bf72110cc59094fadf1fe6bd1a700b[log] [tgz]
authorRohit Agarwal <[email protected]>Mon Aug 17 08:11:22 2020
committerCommit Bot <[email protected]>Mon Aug 17 08:11:22 2020
tree67f6439059e846778e8e7b91c266dd1706024446
parent0a0ad92f38266e4b084259944385ca081b979d12 [diff]
Add incognito interstitial in the AccountPickerBottomSheet.

In the Account picker Dialog we had implemented an option for users
to sign in temporarily via Incognito mode.

This CL adds the functionality of showing an incognito interstitial when
the user clicks on the incognito mode button.

The incognito interstitial is currently blank expect the Learn more
and Continue buttons. The functionality of these buttons and the
contents of the interstitial would be followed up later.

This CL also adds tests to ensure the UI elements of the incognito
interstitial are shown properly and the state switch happened smoothly
and didn't leave any past UI elements.

[email protected]

Bug: 1103262
Change-Id: I031b505fe347afb3265da4921c002a702a022421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346645
Reviewed-by: Rohit Agarwal <[email protected]>
Reviewed-by: Alice Wang <[email protected]>
Commit-Queue: Rohit Agarwal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#798566}
9 files changed
tree: 67f6439059e846778e8e7b91c266dd1706024446
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.