[Extensions] Make Extension::version() return a const base::Version&
Currently, Extension::version() returns a pointer to a constant
base::Version. However, all extensions are required to have a valid
version (if it does not, the Init() call fails). It's perfectly
sufficient to return a const base::Version& here and avoid callers from
having to dereference the return value (which is mostly just cognitive
load).
TBRing for mechanical changes:
[email protected] (c/b/chromeos/login)
[email protected] (c/b/media/router)
[email protected] (c/b/policy)
[email protected] (c/b/safe_browsing/incident_reporting)
[email protected] (c/b/supervised_user)
Bug: None
Change-Id: I233c5822bf32d10a9a1ad0c009b6b566a80a5fd8
Reviewed-on: https://chromium-review.googlesource.com/828580
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#525288}diff --git a/chrome/browser/extensions/extension_sync_data.cc b/chrome/browser/extensions/extension_sync_data.cc
index 1d16eada..7a1b924d 100644
--- a/chrome/browser/extensions/extension_sync_data.cc
+++ b/chrome/browser/extensions/extension_sync_data.cc
@@ -117,7 +117,7 @@
all_urls_enabled_(all_urls_enabled),
installed_by_custodian_(installed_by_custodian),
version_(extension.from_bookmark() ? base::Version("0")
- : *extension.version()),
+ : extension.version()),
update_url_(ManifestURL::GetUpdateURL(&extension)),
name_(extension.non_localized_name()),
app_launch_ordinal_(app_launch_ordinal),
