[Extensions] Make Extension::version() return a const base::Version&
Currently, Extension::version() returns a pointer to a constant
base::Version. However, all extensions are required to have a valid
version (if it does not, the Init() call fails). It's perfectly
sufficient to return a const base::Version& here and avoid callers from
having to dereference the return value (which is mostly just cognitive
load).
TBRing for mechanical changes:
[email protected] (c/b/chromeos/login)
[email protected] (c/b/media/router)
[email protected] (c/b/policy)
[email protected] (c/b/safe_browsing/incident_reporting)
[email protected] (c/b/supervised_user)
Bug: None
Change-Id: I233c5822bf32d10a9a1ad0c009b6b566a80a5fd8
Reviewed-on: https://chromium-review.googlesource.com/828580
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#525288}diff --git a/chrome/browser/supervised_user/supervised_user_service.cc b/chrome/browser/supervised_user/supervised_user_service.cc
index d9892b96..2260272f 100644
--- a/chrome/browser/supervised_user/supervised_user_service.cc
+++ b/chrome/browser/supervised_user/supervised_user_service.cc
@@ -958,7 +958,7 @@
// If the installed version is approved, then the extension is allowed,
// otherwise, it requires approval.
if (extension_it != approved_extensions_map_.end() &&
- extension_it->second == *extension.version()) {
+ extension_it->second == extension.version()) {
return ExtensionState::ALLOWED;
}
return ExtensionState::REQUIRE_APPROVAL;
@@ -1051,7 +1051,7 @@
SupervisedUserService* supervised_user_service =
SupervisedUserServiceFactory::GetForProfile(profile_);
supervised_user_service->AddExtensionInstallRequest(
- extension->id(), *extension->version());
+ extension->id(), extension->version());
}
}
}
@@ -1069,7 +1069,7 @@
ExtensionPrefs* extension_prefs = ExtensionPrefs::Get(profile_);
const std::string& id = extension->id();
- const base::Version& version = *extension->version();
+ const base::Version& version = extension->version();
// If an already approved extension is updated without requiring
// new permissions, we update the approved_version.
