Google Git
Sign in
chromium / chromium / src.git / 3e115b969fe3a256444fb18c74262905bd1afef2
commit3e115b969fe3a256444fb18c74262905bd1afef2[log] [tgz]
authorAlec Douglas <[email protected]>Tue Apr 09 15:18:43 2019
committerCommit Bot <[email protected]>Tue Apr 09 15:18:43 2019
tree24987ba2a0a853c697af3326cddd08460012b18e
parent991094f55720fb86ddb399927f083c4bd3190613 [diff]
Reland "Show controls and update time indicators during seeking" (again)

This reverts commit 57d8bde6a48a121cbf7dc91c08b4c4a8ffaf712c.

Original commit message:
> Show controls and update time indicators during seeking
>
> This commit modifies the MediaControls to show the controls and update
> the current time indicators (current time text + timeline thumb)
> immediately during seek requests so the element behavior during rapid
> seek requests (e.g. user is holding down the FF button on their BT
> keyboard) look similar to when a user is scrubbing the timeline with
> their mouse.
>
> Bug: 748749
>
> TEST=MediaControlsImplTest, manual testing
>      out/Debug/bin/run_webkit_unit_tests -f *MediaControlsImplTest*
>
> Change-Id: I6588aded2a93e081a6ca638ee1da534ea00abf4d
> Reviewed-on: https://chromium-review.googlesource.com/c/1274945
> Commit-Queue: Tommy Steimel <[email protected]>
> Reviewed-by: Mounir Lamouri <[email protected]>
> Reviewed-by: Tommy Steimel <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#636493}

This commit was reverted for causing a layout test
(controls-drag-timebar-rendering.html) to be flaky.

After close examination, it was determined that this layout test was
verifying some functionality that no longer exists, and was
previously passing erroneously. In relanding this commit, that test
has been deleted.

Bug: 937029
Change-Id: I012f767f4a0d072509a7feff199eb6135959534c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558193
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#649106}
10 files changed
tree: 24987ba2a0a853c697af3326cddd08460012b18e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .