Retire WebDisplayMode from C++
The WebDisplayMode enum is redundant in C++ now that we have
blink::mojom::DisplayMode.
The following header is no longer needed:
third_party/blink/public/common/manifest/web_display_mode.h
// TODO(dgozman): instead of this enum, use blink.mojom.DisplayMode directly.
WebDisplayMode.java is added to chrome/android/java/..., replacing the
WebDisplayMode.java file that was previously generated from the above header.
(The mojom-generated Java class DisplayMode is not a direct replacement for
the Java annotation type @WebDisplayMode.)
The DisplayMode enum constants now following the naming guide:
kUndefined kBrowser kMinimalUi kStandalone kFullscreen
https://google.github.io/styleguide/cppguide.html#Constant_Names
[email protected]
[email protected]
[email protected]
Bug: 1009909
Change-Id: Ida01048bd5001e9217601d35a2ef3770d4d7bf54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834804
Commit-Queue: Eric Willigers <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Alexey Baskakov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#702724}
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 94c9675..faa650a 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -422,7 +422,7 @@
int32_t widget_routing_id,
CompositorDependencies* compositor_deps,
PageProperties* page_properties,
- blink::WebDisplayMode display_mode,
+ blink::mojom::DisplayMode display_mode,
bool is_undead,
bool never_visible) {
if (g_create_render_widget_for_frame) {
@@ -441,7 +441,7 @@
int32_t widget_routing_id,
CompositorDependencies* compositor_deps,
PageProperties* page_properties,
- blink::WebDisplayMode display_mode,
+ blink::mojom::DisplayMode display_mode,
bool hidden,
bool never_visible,
mojo::PendingReceiver<mojom::Widget> widget_receiver) {
@@ -453,7 +453,7 @@
RenderWidget::RenderWidget(int32_t widget_routing_id,
CompositorDependencies* compositor_deps,
PageProperties* page_properties,
- blink::WebDisplayMode display_mode,
+ blink::mojom::DisplayMode display_mode,
bool is_undead,
bool hidden,
bool never_visible,
