Google Git
Sign in
chromium / chromium / src.git / 551bd2239da30ed0f49d3f8fadfcd3b0f036cbbc
commit551bd2239da30ed0f49d3f8fadfcd3b0f036cbbc[log] [tgz]
authorConnie Wan <[email protected]>Thu Nov 21 15:29:51 2019
committerCommit Bot <[email protected]>Thu Nov 21 15:29:51 2019
tree3698743ffb6a7f1bb79b284963b1b724b7135394
parent825b9883f937af7ece0967553c1eacb85e3dd254 [diff]
Refactor Tab Groups part 1

Pulled out TabGroupModel and TabGroup from TabStripModel. See the comments in each class for how they're used. See also the TODOs in the comments for how this can be further improved in future CLs (working on this next).

The API in TabStripController still remains despite my best efforts to get rid of it. For now that seems better because I have to touch fewer things while refactoring. Eventually I'm interested in seeing how we can avoid duplicating APIs across models and controllers, which is a bigger philosophical question.

Change-Id: I96130622ab939de7d986c7e3dd1b19b476658f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915194
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Taylor Bergquist <[email protected]>
Commit-Queue: Connie Wan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#717648}
18 files changed
tree: 3698743ffb6a7f1bb79b284963b1b724b7135394
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .