[ntp][modules] Add about flags for shopping tasks module
Fixed: 1133411
Change-Id: Ib6ad0c6becd6d54ad9be1e1d1fb4a11828e7c214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436655
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#812533}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 7a992fd..f673e29 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1528,6 +1528,12 @@
kPromoBrowserCommandOpenSafeBrowsingSettingsCommandParam,
base::size(kPromoBrowserCommandOpenSafeBrowsingSettingsCommandParam),
nullptr}};
+#if !defined(OS_ANDROID)
+const FeatureEntry::FeatureVariation kNtpShoppingTasksModuleVariations[] = {
+ {"- Real Data", {}, 0, "t4445867" /* variation_id */},
+ {"- Fake Data", {}, 0, "t4445868" /* variation_id */},
+};
+#endif // !defined(OS_ANDROID)
#if defined(OS_ANDROID)
const FeatureEntry::FeatureParam kTranslateForceTriggerOnEnglishHeuristic[] = {
@@ -4326,6 +4332,13 @@
{"ntp-modules", flag_descriptions::kNtpModulesName,
flag_descriptions::kNtpModulesDescription, kOsDesktop,
FEATURE_VALUE_TYPE(ntp_features::kModules)},
+
+ {"ntp-shopping-tasks-module",
+ flag_descriptions::kNtpShoppingTasksModuleName,
+ flag_descriptions::kNtpShoppingTasksModuleDescription, kOsDesktop,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(ntp_features::kNtpShoppingTasksModule,
+ kNtpShoppingTasksModuleVariations,
+ "NtpShoppingTasksModule")},
#endif // !defined(OS_ANDROID)
#if defined(DCHECK_IS_CONFIGURABLE)
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index a02b211..fa131f6 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -3227,6 +3227,11 @@
"expiry_milestone": 89
},
{
+ "name": "ntp-shopping-tasks-module",
+ "owners": [ "aee", "mahmadi", "tiborg" ],
+ "expiry_milestone": 90
+ },
+ {
"name": "ntp-webui",
"owners": [ "aee", "mahmadi", "tiborg" ],
"expiry_milestone": 87
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index c411982..f87ac96 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -3307,6 +3307,10 @@
const char kNtpModulesName[] = "NTP Modules";
const char kNtpModulesDescription[] = "Shows modules on the New Tab Page.";
+const char kNtpShoppingTasksModuleName[] = "NTP Shopping Tasks Module";
+const char kNtpShoppingTasksModuleDescription[] =
+ "Shows the shopping tasks module on the New Tab Page.";
+
const char kEnableReaderModeName[] = "Enable Reader Mode";
const char kEnableReaderModeDescription[] =
"Allows viewing of simplified web pages by selecting 'Customize and "
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index f96646c..2e86c42 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -1888,6 +1888,9 @@
extern const char kNtpModulesName[];
extern const char kNtpModulesDescription[];
+extern const char kNtpShoppingTasksModuleName[];
+extern const char kNtpShoppingTasksModuleDescription[];
+
extern const char kEnableReaderModeName[];
extern const char kEnableReaderModeDescription[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index bc1a8be2..cbe7cdd 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -42288,6 +42288,7 @@
<int value="-793383355" label="StrictOriginIsolation:enabled"/>
<int value="-792785226" label="TemporaryUnexpireFlagsM78:disabled"/>
<int value="-792079435" label="EnableAppsGridGapFeature:disabled"/>
+ <int value="-790900615" label="NtpShoppingTasksModule:disabled"/>
<int value="-790036192" label="overscroll-start-threshold"/>
<int value="-787969387" label="HTTPSServerPreviewsUsingURLLoader:enabled"/>
<int value="-787876637" label="HomeLauncherGestures:enabled"/>
@@ -44723,6 +44724,7 @@
<int value="1731522433" label="enable-offer-store-unmasked-wallet-cards"/>
<int value="1731612996" label="CrostiniFiles:disabled"/>
<int value="1733390925" label="force-enable-stylus-tools"/>
+ <int value="1734685331" label="NtpShoppingTasksModule:enabled"/>
<int value="1735934914" label="OverlayScrollbarFlashWhenMouseEnter:disabled"/>
<int value="1736698988" label="FsNosymfollow:disabled"/>
<int value="1738520473" label="SystemTrayMicGainSetting:disabled"/>
