Enable GN check for gpu and rlz
Rlz already passed on Windows.
GPU had a bunch of errors which are fixed here by adding the necessary dependencies and in a few cases removing unnecessary headers.
gpu_memory_buffer_manager.h included stuff from ui/gfx but adding a dependency on //ui/gfx pulls Skia into the NaCl IRT (and mesa into Android) and everything goes badly. The GPU memory buffer stuff turns out to be separable from gfx so I created a new target for this.
The same is true for ui/gfx/native_widget_types.h (this is just some enums in a .h file) so I made a separate target for this as well.
In support of the Skia-in-NaCl problem, I added an assert_no_deps annotation on the NaCl IRT so people will get an error if they accidentally add this Skia dependency (this has come up before, it's easy to add a //ui/gfx dependency in the wrong place). It also fixes the Skia build in NaCl by updating the condition for extra warning to match build config. Without this update, the assert_no_deps won't be reached before an error running the skia build file, which won't make any sense in the context of addnig a random dependency.
Minor cleanup of the use_libpci conditionals that was exposed by this (the define that controlled the header didn't exactly match the corresponding dependencies).
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=jschuh (gpu/ipc build changes)
Review URL: https://codereview.chromium.org/1800343002
Cr-Commit-Position: refs/heads/master@{#381881}
diff --git a/gpu/command_buffer/service/BUILD.gn b/gpu/command_buffer/service/BUILD.gn
index 7b95924..7ad6816d 100644
--- a/gpu/command_buffer/service/BUILD.gn
+++ b/gpu/command_buffer/service/BUILD.gn
@@ -145,6 +145,8 @@
"//base",
"//base/third_party/dynamic_annotations",
"//crypto",
+ "//gpu/command_buffer/client:client_sources",
+ "//gpu/command_buffer/common:gles2_utils",
"//gpu/config:config_sources",
"//third_party/angle:commit_id",
"//third_party/angle:translator",
