Add metrics to check for possible regression for SyncManualStartAndroid feature
As this feature is rolled out it is important to make sure sync does not break for existing syncing users. These metrics should help measure possible regressions.
Design doc: go/clank-safe-advanced-sync-flow
Bug: 996276
Change-Id: I23082e1be6ef4a5042a08c519dd0c6ee4547fdf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764193
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Cr-Commit-Position: refs/heads/master@{#695631}
diff --git a/chrome/browser/extensions/extension_service_sync_unittest.cc b/chrome/browser/extensions/extension_service_sync_unittest.cc
index b7e69b88..216de842 100644
--- a/chrome/browser/extensions/extension_service_sync_unittest.cc
+++ b/chrome/browser/extensions/extension_service_sync_unittest.cc
@@ -94,6 +94,8 @@
const char good_crx[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf";
const char page_action[] = "obcimlgaoabeegjmmpldobjndiealpln";
const char theme2_crx[] = "ibcijncamhmjjdodjamgiipcgnnaeagd";
+const syncer::SyncFirstSetupCompleteSource kSetSourceFromTest =
+ syncer::SyncFirstSetupCompleteSource::BASIC_FLOW;
#if BUILDFLAG(ENABLE_SUPERVISED_USERS)
const char autoupdate[] = "ogjcoiohnmldgjemafoockdghcjciccf";
@@ -354,7 +356,7 @@
// The user has enabled sync.
syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
- sync_service->GetUserSettings()->SetFirstSetupComplete();
+ sync_service->GetUserSettings()->SetFirstSetupComplete(kSetSourceFromTest);
service()->Init();
ASSERT_TRUE(service()->is_ready());
@@ -391,7 +393,7 @@
// Enable sync.
syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
- sync_service->GetUserSettings()->SetFirstSetupComplete();
+ sync_service->GetUserSettings()->SetFirstSetupComplete(kSetSourceFromTest);
service()->Init();
@@ -473,7 +475,7 @@
// Enable sync.
syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
- sync_service->GetUserSettings()->SetFirstSetupComplete();
+ sync_service->GetUserSettings()->SetFirstSetupComplete(kSetSourceFromTest);
service()->Init();
@@ -539,7 +541,7 @@
// The user has enabled sync.
syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
- sync_service->GetUserSettings()->SetFirstSetupComplete();
+ sync_service->GetUserSettings()->SetFirstSetupComplete(kSetSourceFromTest);
// Make sure ExtensionSyncService is created, so it'll be notified of changes.
extension_sync_service();
@@ -602,7 +604,7 @@
// The user has enabled sync.
ProfileSyncServiceFactory::GetForProfile(profile())
->GetUserSettings()
- ->SetFirstSetupComplete();
+ ->SetFirstSetupComplete(kSetSourceFromTest);
// Make sure ExtensionSyncService is created, so it'll be notified of changes.
extension_sync_service();
@@ -1732,7 +1734,7 @@
// The user has enabled sync.
ProfileSyncServiceFactory::GetForProfile(profile())
->GetUserSettings()
- ->SetFirstSetupComplete();
+ ->SetFirstSetupComplete(kSetSourceFromTest);
// Make sure ExtensionSyncService is created, so it'll be notified of changes.
extension_sync_service();
@@ -2663,7 +2665,7 @@
// Enable sync.
syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
- sync_service->GetUserSettings()->SetFirstSetupComplete();
+ sync_service->GetUserSettings()->SetFirstSetupComplete(kSetSourceFromTest);
test_blacklist_.Attach(service()->blacklist_);
service()->Init();
