Use specific icon and card identifier for Google issued cards
Introduced a new flag which controls whether the card is returned by
personal_data_manager and also used for determining the string and icon
shown in the autofill suggestion pop up. The string and icons are
placeholders for now and will be updated later when the UI is finalized.
Please refer to bug for design doc.
Bug: 1063426
Change-Id: I515c6c73e3d87c32f62485ee75dd67c2e2e62c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151831
Commit-Queue: Siddharth Shah <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/heads/master@{#761788}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index e9ab4412..6314f6d 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -5326,6 +5326,11 @@
flag_descriptions::kEnableExperimentalCookieFeaturesDescription, kOsAll,
MULTI_VALUE_TYPE(kEnableExperimentalCookieFeaturesChoices)},
+ {"autofill-enable-google-issued-card",
+ flag_descriptions::kAutofillEnableGoogleIssuedCardName,
+ flag_descriptions::kAutofillEnableGoogleIssuedCardDescription, kOsAll,
+ FEATURE_VALUE_TYPE(autofill::features::kAutofillEnableGoogleIssuedCard)},
+
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
@@ -5410,8 +5415,8 @@
#endif // OS_WIN
if (!strcmp("dns-over-https", entry.internal_name) &&
- (SystemNetworkContextManager::GetStubResolverConfigReader()->
- ShouldDisableDohForManaged() ||
+ (SystemNetworkContextManager::GetStubResolverConfigReader()
+ ->ShouldDisableDohForManaged() ||
features::kDnsOverHttpsShowUiParam.Get())) {
return true;
}
