cros: Convert "touch hud projection" from key shortcut/pref to flag
This debugging/presentation feature was tied to Ctrl-Alt-P. Usage is
very low per UMA metrics. We suspect most usage was from users
mistakenly hitting it when pressing Ctrl-P to print. Since it was tied
to a pref the user could get stuck in this state. It also didn't work
at the login screen and would turn on and off when switching
multiprofile users.
This feature is useful for debugging, recording videos of touch bugs,
and for projecting demos. UI review suggested moving it to about:flags
alongside the other touch debug flags.
* Remove the pref and add cleanup code to wipe the existing value.
* Remove the accelerator key.
* Add --show-taps. The name is inspired by the Android OS developer
option that does the same thing.
[email protected]
Bug: 786115
Test: existing ash_unittests
Change-Id: I07579bff6ab3dd16ec5c14347df1a047b1aa935c
Reviewed-on: https://chromium-review.googlesource.com/802075
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#521058}diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index 5ce6f5c2..6141903 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -781,9 +781,6 @@
extern const char kEnableShowSavedCopySecondary[];
extern const char kDisableShowSavedCopy[];
-extern const char kShowTouchHudName[];
-extern const char kShowTouchHudDescription[];
-
extern const char kSilentDebuggerExtensionApiName[];
extern const char kSilentDebuggerExtensionApiDescription[];
@@ -1776,6 +1773,12 @@
extern const char kMaterialDesignInkDropAnimationFast[];
extern const char kMaterialDesignInkDropAnimationSlow[];
+extern const char kShowTapsName[];
+extern const char kShowTapsDescription[];
+
+extern const char kShowTouchHudName[];
+extern const char kShowTouchHudDescription[];
+
extern const char kUiShowCompositedLayerBordersName[];
extern const char kUiShowCompositedLayerBordersDescription[];
extern const char kUiShowCompositedLayerBordersRenderPass[];
