Extend URLLoader mojo interface to support pause/resume caching response body.
Two methods are added:
- PauseCachingResponseBody();
- ResumeCachingResponseBody();
These methods will be used later by ThrottlingURLLoader. When it gets
notified by SafeBrowsing that a resource is potentially unsafe, it needs
to notify the network service to pause caching. That way we minimize the
time window in which the network service could write unsafe resources
into disk cache.
The reason *not* to introduce Pause/Resume() instead: although they are more
general-purposed, Pause/Resume() apply to all kinds of URLLoaders which means
we will need to implement these methods for all of them. That would be a
waste of effort because the current use case only cares about pause/resume
caching when fetching from network.
This CL only changes the interface. The actual implementation in network
service will be in a follow-up CL.
BUG=715673
Change-Id: If718e5aeabe0019c91dd95e9b988f8dda3d861c6
Reviewed-on: https://chromium-review.googlesource.com/667783
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Yuzhu Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#502464}diff --git a/content/browser/loader/mojo_async_resource_handler.cc b/content/browser/loader/mojo_async_resource_handler.cc
index 505bfed..d42ac3d 100644
--- a/content/browser/loader/mojo_async_resource_handler.cc
+++ b/content/browser/loader/mojo_async_resource_handler.cc
@@ -382,6 +382,14 @@
request(), priority, intra_priority_value);
}
+void MojoAsyncResourceHandler::PauseCachingResponseBody() {
+ NOTREACHED();
+}
+
+void MojoAsyncResourceHandler::ResumeCachingResponseBody() {
+ NOTREACHED();
+}
+
void MojoAsyncResourceHandler::OnWritableForTesting() {
OnWritable(MOJO_RESULT_OK);
}
