Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`.
DO NOT REVERT (unless absolutely necessary)! Report build breaks to keishi@(APAC)/glazunov@(EMEA)/sebmarchand@(NA) as soon as you see them. Fixes are expected to be trivial.
This commit was generated automatically, by running the following script: tools/clang/rewrite_raw_ptr_fields/rewrite-multiple-platforms.sh on commit fe74bc434e5b7e92d13a328362fcb6df15d8847e
For more information, see MiraclePtr One Pager [1], the PSA at chromium-dev@ [2], and the raw_ptr documentation in //base/memory/raw_ptr.md.
FYI This CL does not enable MiraclePtr protection and we expect no behavior change from this.
[1] https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg/edit?usp=sharing
[2] https://groups.google.com/a/chromium.org/g/chromium-dev/c/vAEeVifyf78/m/SkBUc6PhBAAJ
Binary-Size: Increase of around 500kb was approved for MiraclePtr
Include-Ci-Only-Tests: true
No-Tree-Checks: true
No-Presubmit: true
Bug: 1272324, 1073933
Change-Id: I05c86a83bbb4b3f4b017f361dd7f4e7437697f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Bartek Nowierski <[email protected]>
Owners-Override: Bartek Nowierski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#945735}
diff --git a/ipc/ipc_channel_mojo_unittest.cc b/ipc/ipc_channel_mojo_unittest.cc
index fe89a855..e5f5d05 100644
--- a/ipc/ipc_channel_mojo_unittest.cc
+++ b/ipc/ipc_channel_mojo_unittest.cc
@@ -18,6 +18,7 @@
#include "base/files/scoped_temp_dir.h"
#include "base/location.h"
#include "base/memory/platform_shared_memory_region.h"
+#include "base/memory/raw_ptr.h"
#include "base/memory/read_only_shared_memory_region.h"
#include "base/memory/shared_memory_mapping.h"
#include "base/memory/unsafe_shared_memory_region.h"
@@ -121,7 +122,7 @@
}
private:
- IPC::Sender* sender_ = nullptr;
+ raw_ptr<IPC::Sender> sender_ = nullptr;
base::OnceClosure quit_closure_;
};
@@ -750,7 +751,7 @@
private:
void OnQuitAck() { std::move(quit_closure_).Run(); }
- IPC::Channel* channel_ = nullptr;
+ raw_ptr<IPC::Channel> channel_ = nullptr;
mojo::AssociatedRemote<IPC::mojom::SimpleTestDriver> driver_;
base::OnceClosure quit_closure_;
};
@@ -1180,7 +1181,7 @@
return true;
}
- int32_t* storage_;
+ raw_ptr<int32_t> storage_;
};
TEST_F(IPCChannelProxyMojoTest, SyncAssociatedInterface) {
@@ -1413,7 +1414,7 @@
}
private:
- base::queue<int32_t>* expected_values_;
+ raw_ptr<base::queue<int32_t>> expected_values_;
base::OnceClosure quit_closure_;
};
