Fixes for re-enabling more MSVC level 4 warnings: courgette/ edition
This contains fixes for the following sorts of issues:
* Signedness mismatch
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/371153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281696 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/courgette/disassembler_elf_32.h b/courgette/disassembler_elf_32.h
index dc44ec5..58e2eba 100644
--- a/courgette/disassembler_elf_32.h
+++ b/courgette/disassembler_elf_32.h
@@ -30,7 +30,7 @@
// class encapsulates this behavior. public for use in unit tests.
class TypedRVA {
public:
- explicit TypedRVA(RVA rva) : rva_(rva), offset_(-1) {
+ explicit TypedRVA(RVA rva) : rva_(rva), offset_(static_cast<size_t>(-1)) {
}
virtual ~TypedRVA() { };
diff --git a/courgette/disassembler_elf_32_arm.cc b/courgette/disassembler_elf_32_arm.cc
index dc3712f..f0f94b9 100644
--- a/courgette/disassembler_elf_32_arm.cc
+++ b/courgette/disassembler_elf_32_arm.cc
@@ -215,7 +215,7 @@
case ARM_OFF21:
return 4;
default:
- return -1;
+ return 0xFFFF;
}
}
diff --git a/courgette/encoded_program.cc b/courgette/encoded_program.cc
index 8fb8c695..b78e7fe 100644
--- a/courgette/encoded_program.cc
+++ b/courgette/encoded_program.cc
@@ -710,7 +710,7 @@
class RelocBlock {
public:
RelocBlock() {
- pod.page_rva = ~0;
+ pod.page_rva = 0xFFFFFFFF;
pod.block_size = 8;
}
