[omnibox] Allow to enable on device head suggest for incognito from
chrome://flags.
Tested on both Pixel 2 XL & iPhone X.
Also tested against Finch experiments on Pixel 2 XL by opting in some
ongoing OnDeviceHeadSuggest and Omniboxbundled studies on [canary,
dev, beta, stable] channels and didn't find any problem.
Bug: 925072
Change-Id: I2c127bdb950bc9e70ff82672933bb7322198bd12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952174
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Ce Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#723186}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index ca949042..24fa4dc 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1311,6 +1311,19 @@
nullptr}};
#endif // OS_ANDROID
+const FeatureEntry::FeatureParam kOmniboxOnDeviceHeadSuggestAlwaysServe[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestIncognitoServeMode,
+ "always-serve"}};
+const FeatureEntry::FeatureParam kOmniboxOnDeviceHeadSuggestIncognitoOnly[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestIncognitoServeMode,
+ "incognito-only"}};
+const FeatureEntry::FeatureVariation
+ kOmniboxOnDeviceHeadSuggestIncognitoVariations[] = {
+ {"both-normal-and-incognito", kOmniboxOnDeviceHeadSuggestAlwaysServe,
+ base::size(kOmniboxOnDeviceHeadSuggestAlwaysServe), nullptr},
+ {"incognito-only", kOmniboxOnDeviceHeadSuggestIncognitoOnly,
+ base::size(kOmniboxOnDeviceHeadSuggestIncognitoOnly), nullptr}};
+
const FeatureEntry::FeatureParam
kQuietNotificationPromptsWithAdaptiveActivation[] = {
{QuietNotificationPermissionUiConfig::kEnableAdaptiveActivation,
@@ -2751,7 +2764,10 @@
{"omnibox-on-device-head-suggestions",
flag_descriptions::kOmniboxOnDeviceHeadSuggestionsName,
flag_descriptions::kOmniboxOnDeviceHeadSuggestionsDescription, kOsAll,
- FEATURE_VALUE_TYPE(omnibox::kOnDeviceHeadProvider)},
+ FEATURE_WITH_PARAMS_VALUE_TYPE(
+ omnibox::kOnDeviceHeadProvider,
+ kOmniboxOnDeviceHeadSuggestIncognitoVariations,
+ "OmniboxOnDeviceHeadSuggest")},
{"omnibox-on-focus-suggestions",
flag_descriptions::kOmniboxOnFocusSuggestionsName,
