commit 1076ee2bf342a2e442456a1b795bdc5668b3e63f
author tzik <tzik@chromium.org> Fri Aug 25 04:03:57 2017
committer Commit Bot <commit-bot@chromium.org> Fri Aug 25 04:03:57 2017
tree a1a5cb2528a35ac2de09071a2b3a9ee059f59479
parent bc9dd77abc396e48a6de5b0b1ea9a34c6953cb5a

Apply base_bind_rewriters to //content/renderer/input

This CL applies //tools/clang/base_bind_rewriters to //content/renderer/input
It rewrites base::Bind to base::BindOnce where the resulting base::Callback
is immediately converted to base::OnceCallback, which is considered safe
to use base::BindOnce.

E.g.:
  base::PostTask(FROM_HERE, base::Bind([]{}));
  base::OnceClosure cb = base::Bind([]{});
are converted to:
  base::PostTask(FROM_HERE, base::BindOnce([]{}));
  base::OnceClosure cb = base::BindOnce([]{});

Change-Id: I54d839c5d69736a063f39b843b7314c185118ed4
Reviewed-on: https://chromium-review.googlesource.com/628054
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497320}

content/renderer/input/widget_input_handler_impl.cc

diff --git a/content/renderer/input/widget_input_handler_impl.cc b/content/renderer/input/widget_input_handler_impl.cc
index e619ee8..b731df44 100644
--- a/content/renderer/input/widget_input_handler_impl.cc
+++ b/content/renderer/input/widget_input_handler_impl.cc
@@ -72,35 +72,36 @@
     mojom::WidgetInputHandlerAssociatedRequest request) {
   associated_binding_.Bind(std::move(request));
   associated_binding_.set_connection_error_handler(
-      base::Bind(&WidgetInputHandlerImpl::Release, base::Unretained(this)));
+      base::BindOnce(&WidgetInputHandlerImpl::Release, base::Unretained(this)));
 }
 
 void WidgetInputHandlerImpl::SetBinding(
     mojom::WidgetInputHandlerRequest request) {
   binding_.Bind(std::move(request));
   binding_.set_connection_error_handler(
-      base::Bind(&WidgetInputHandlerImpl::Release, base::Unretained(this)));
+      base::BindOnce(&WidgetInputHandlerImpl::Release, base::Unretained(this)));
 }
 
 void WidgetInputHandlerImpl::SetFocus(bool focused) {
   RunOnMainThread(
-      base::Bind(&RenderWidget::OnSetFocus, render_widget_, focused));
+      base::BindOnce(&RenderWidget::OnSetFocus, render_widget_, focused));
 }
 
 void WidgetInputHandlerImpl::MouseCaptureLost() {
   RunOnMainThread(
-      base::Bind(&RenderWidget::OnMouseCaptureLost, render_widget_));
+      base::BindOnce(&RenderWidget::OnMouseCaptureLost, render_widget_));
 }
 
 void WidgetInputHandlerImpl::SetEditCommandsForNextKeyEvent(
     const std::vector<EditCommand>& commands) {
-  RunOnMainThread(base::Bind(&RenderWidget::OnSetEditCommandsForNextKeyEvent,
-                             render_widget_, commands));
+  RunOnMainThread(
+      base::BindOnce(&RenderWidget::OnSetEditCommandsForNextKeyEvent,
+                     render_widget_, commands));
 }
 
 void WidgetInputHandlerImpl::CursorVisibilityChanged(bool visible) {
-  RunOnMainThread(base::Bind(&RenderWidget::OnCursorVisibilityChange,
-                             render_widget_, visible));
+  RunOnMainThread(base::BindOnce(&RenderWidget::OnCursorVisibilityChange,
+                                 render_widget_, visible));
 }
 
 void WidgetInputHandlerImpl::ImeSetComposition(
@@ -110,9 +111,9 @@
     int32_t start,
     int32_t end) {
   RunOnMainThread(
-      base::Bind(&RenderWidget::OnImeSetComposition, render_widget_, text,
-                 ConvertUIImeTextSpansToBlinkImeTextSpans(ime_text_spans),
-                 range, start, end));
+      base::BindOnce(&RenderWidget::OnImeSetComposition, render_widget_, text,
+                     ConvertUIImeTextSpansToBlinkImeTextSpans(ime_text_spans),
+                     range, start, end));
 }
 
 void WidgetInputHandlerImpl::ImeCommitText(
@@ -121,26 +122,26 @@
     const gfx::Range& range,
     int32_t relative_cursor_position) {
   RunOnMainThread(
-      base::Bind(&RenderWidget::OnImeCommitText, render_widget_, text,
-                 ConvertUIImeTextSpansToBlinkImeTextSpans(ime_text_spans),
-                 range, relative_cursor_position));
+      base::BindOnce(&RenderWidget::OnImeCommitText, render_widget_, text,
+                     ConvertUIImeTextSpansToBlinkImeTextSpans(ime_text_spans),
+                     range, relative_cursor_position));
 }
 
 void WidgetInputHandlerImpl::ImeFinishComposingText(bool keep_selection) {
-  RunOnMainThread(base::Bind(&RenderWidget::OnImeFinishComposingText,
-                             render_widget_, keep_selection));
+  RunOnMainThread(base::BindOnce(&RenderWidget::OnImeFinishComposingText,
+                                 render_widget_, keep_selection));
 }
 
 void WidgetInputHandlerImpl::RequestTextInputStateUpdate() {
-  RunOnMainThread(
-      base::Bind(&RenderWidget::OnRequestTextInputStateUpdate, render_widget_));
+  RunOnMainThread(base::BindOnce(&RenderWidget::OnRequestTextInputStateUpdate,
+                                 render_widget_));
 }
 
 void WidgetInputHandlerImpl::RequestCompositionUpdates(bool immediate_request,
                                                        bool monitor_request) {
-  RunOnMainThread(base::Bind(&RenderWidget::OnRequestCompositionUpdates,
-                             render_widget_, immediate_request,
-                             monitor_request));
+  RunOnMainThread(base::BindOnce(&RenderWidget::OnRequestCompositionUpdates,
+                                 render_widget_, immediate_request,
+                                 monitor_request));
 }
 
 void WidgetInputHandlerImpl::DispatchEvent(
@@ -172,8 +173,8 @@
     associated_binding_.Close();
     binding_.Close();
     main_thread_task_runner_->PostTask(
-        FROM_HERE,
-        base::Bind(&WidgetInputHandlerImpl::Release, base::Unretained(this)));
+        FROM_HERE, base::BindOnce(&WidgetInputHandlerImpl::Release,
+                                  base::Unretained(this)));
     return;
   }
   delete this;