Google Git
Sign in
chromium / chromium / src.git / 10d62c1f9644ea1aeaa5300c1714b0813fbd7b2f
commit10d62c1f9644ea1aeaa5300c1714b0813fbd7b2f[log] [tgz]
authorChristian Dullweber <[email protected]>Mon Aug 19 12:08:19 2019
committerCommit Bot <[email protected]>Mon Aug 19 12:08:19 2019
tree3247cd016cb0782af52269a4be35e06783b61e84
parent77d2bd375eec735257fb206784d738a197b2e4d6 [diff]
Reland "Pass top frame origin to cookie settings"

This is a reland of b21dff94e34c617b52a335ecf531b8010c9a3fa4

This CL wasn't the cause of renderer crashes. crbug.com/994537#c21

Original change's description:
> Pass top frame origin to cookie settings
>
> In order to correctly apply content settings with secondary patterns,
> CookieSettings needs to know the TopFrameOrigin of a request.
> Currently it only has access to SiteForCookies, which can be an empty
> url for cross-origin iframes.
> This CL passes TopFrameOrigin from UrlRequests to CookieSettings and
> uses this value to look up ContentSettings. SiteForOrigin is still
> used to determine whether the cookie is used in a third-party context.
>
> As TopFrameOrigin is not yet always available, this new behavior is
> behind the ImprovedCookieControls flag.
>
> Bug: 988398
> Change-Id: Ibb6180b68ae9f4780046be6fb2a9dcbb39f9ccf4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698419
> Commit-Queue: Christian Dullweber <[email protected]>
> Reviewed-by: Roger Tawa <[email protected]>
> Reviewed-by: Balazs Engedy <[email protected]>
> Reviewed-by: Mike West <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Reviewed-by: Arthur Sonzogni <[email protected]>
> Reviewed-by: John Rummell <[email protected]>
> Reviewed-by: Nate Fischer <[email protected]>
> Reviewed-by: Maks Orlovich <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#686759}

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]

Bug: 988398, 994557
Change-Id: I9adf51d62326e75374bc41145e30f377c540f82d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760212
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#688063}
35 files changed
tree: 3247cd016cb0782af52269a4be35e06783b61e84
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .