Google Git
Sign in
chromium / chromium / src.git / 118223f4940952025b755aa496260c1994c89e03
commit118223f4940952025b755aa496260c1994c89e03[log] [tgz]
authorFrancois Doray <[email protected]>Wed Dec 04 17:00:28 2019
committerCommit Bot <[email protected]>Wed Dec 04 17:00:28 2019
treee25c83176e896d477af63754f8a86f5af6bb1803
parent2de8091214ee6667e11235f6cfb1f86e08f82cc3 [diff]
[sequencemanager] Do not set |delayed_run_time| for immediate tasks.

Prior to this CL, the SequenceManager set |PendingTask::delayed_run_time|
for immediate tasks when the "add queue time to tasks" option was
enabled. This caused the responsiveness watcher to consider an interval
as janky only when a long task was running, not when a task was queued
for a long time as intended.

With this CL, SequenceManager only sets |PendingTask::delayed_run_time|
for delayed tasks. The responsiveness watcher is modified to keep
recording the same jank as before, to ensure that we can easily notice
if there are real jank regressions. In an upcoming CL, we will modify
the responsiveness watcher to record a new jank histogram that takes
into account queuing time.

Bug: 1029137
Change-Id: I8394cb42a8b6d77b01eb38cad1242fc4b0f6c74d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940452
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: Alex Clarke <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#721511}
10 files changed
tree: e25c83176e896d477af63754f8a86f5af6bb1803
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .