Google Git
Sign in
chromium / chromium / src.git / 7722bedfc91a8b03ba7209781bdc9385493650b9
commit7722bedfc91a8b03ba7209781bdc9385493650b9[log] [tgz]
authorRayan Kanso <[email protected]>Mon May 14 14:04:16 2018
committerCommit Bot <[email protected]>Mon May 14 14:04:16 2018
tree2eaa19049a7fd42044b3fb0ecb2512f2b743d788
parentb710e60381a933bec9ba59993e626f6979f0b19e [diff]
Fix IDL compiler dictionary ImplementedAs bug

The dependencies in the build rule use the name of the idl file
containing the dictionary defintion. For the cases where ImplementedAs
is used, the build rule will fail since the generated file matches the
ImplementedAs value.

This CL changes the file name of the generated dictionary implementation
to match the idl name rather than the ImplementedAs name.

Bug: 839847
Change-Id: Ic5d9dfc82ba90188e26f1206465eb790dc8a193b
Reviewed-on: https://chromium-review.googlesource.com/1044217
Commit-Queue: Rayan Kanso <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#558291}
3 files changed
tree: 2eaa19049a7fd42044b3fb0ecb2512f2b743d788
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .