Rename IdnNavigationSuggestions feature to LookalikeUrlNavigationSuggestions
Also rename any related classes. In the future we might show suggestions for
non-IDN navigations as well, this is to prepare for that.
Bug: 843361,847662
Change-Id: Id614decdc1b108923d6934c66b99274a2477e0a3
Reviewed-on: https://chromium-review.googlesource.com/1187227
Commit-Queue: Mustafa Emre Acer <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#587283}diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 5075d1fd..6b0bcf9 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -484,13 +484,15 @@
};
#endif // OS_CHROMEOS
-const FeatureEntry::FeatureParam kIdnNavigationSuggestionsMetricsOnly[] = {
- {"metrics_only", "true"},
+const FeatureEntry::FeatureParam
+ kLookalikeUrlNavigationSuggestionsMetricsOnly[] = {
+ {"metrics_only", "true"},
};
-const FeatureEntry::FeatureVariation kIdnNavigationSuggestionVariants[] = {
- {"With Metrics Only", kIdnNavigationSuggestionsMetricsOnly,
- base::size(kIdnNavigationSuggestionsMetricsOnly)}};
+const FeatureEntry::FeatureVariation
+ kLookalikeUrlNavigationSuggestionsVariants[] = {
+ {"With Metrics Only", kLookalikeUrlNavigationSuggestionsMetricsOnly,
+ base::size(kLookalikeUrlNavigationSuggestionsMetricsOnly)}};
const FeatureEntry::Choice kExtensionContentVerificationChoices[] = {
{flags_ui::kGenericExperimentChoiceDefault, "", ""},
@@ -4308,12 +4310,14 @@
FEATURE_VALUE_TYPE(features::kIncognitoStrings)},
#endif
- {"enable-idn-navigation-suggestions",
- flag_descriptions::kIdnNavigationSuggestionsName,
- flag_descriptions::kIdnNavigationSuggestionsDescription, kOsDesktop,
- FEATURE_WITH_PARAMS_VALUE_TYPE(features::kIdnNavigationSuggestions,
- kIdnNavigationSuggestionVariants,
- "IdnNavigationSuggestions")},
+ {"enable-lookalike-url-navigation-suggestions",
+ flag_descriptions::kLookalikeUrlNavigationSuggestionsName,
+ flag_descriptions::kLookalikeUrlNavigationSuggestionsDescription,
+ kOsDesktop,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(
+ features::kLookalikeUrlNavigationSuggestions,
+ kLookalikeUrlNavigationSuggestionsVariants,
+ "LookalikeUrlNavigationSuggestions")},
#if defined(OS_ANDROID)
{"long-press-back-for-history",
