buildtools: remove clang_format from buildtools/DEPS
clang_format was in both DEPS and buildtools/DEPS. After this
change, it's only in DEPS.
This is used by `git cl format`, so if your project uses that,
it will now have to also deps in buildtools/clang_format/script
explicitly. Edit your toplevel DEPS file to have something like
'clang_format_revision': '99803d74e35962f63a775f29477882afd4d57d94',
in its `vars =` section, and an entry similar to
'src/buildtools/clang_format/script':
Var('chromium_git') +
'/external/github.com/llvm/llvm-project/clang/tools/clang-format.git@' +
Var('clang_format_revision'),
in its `deps =` section. Adopt to your project's style as you like.
(Maybe you don't want an explicit variable for the revision, maybe
your toplevel directory is not called "src", maybe
chromium.googlesource.com is known by something other than
chromium_git.)
This revision only controls the clang-format scripts, not the
clang-format binary.
These scripts are updated rarely, and they change in behavior even less
often. You can probably just pin that revision and be good for years.
But if you want, you can set up an autoroller, or roll it transitively
through Chromium's DEPS file when you roll //build, //buildtools, etc.
Bug: 1177288
Change-Id: Ic6ed50d7a318f5da5fcb99e9ad050a8f3bb07cc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2732611
Auto-Submit: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#860551}
diff --git a/DEPS b/DEPS
index 4c1a02f..765d34a77 100644
--- a/DEPS
+++ b/DEPS
@@ -376,6 +376,11 @@
# the commit queue can handle CLs rolling feed
# and whatever else without interference from each other.
'libunwind_revision': '8869f42e7fc234f038cd78097e19e304773cc8f0',
+ # Three lines of non-changing comments so that
+ # the commit queue can handle CLs rolling feed
+ # and whatever else without interference from each other.
+ # TODO(crbug.com/1166332) rename to clang_format_revision.
+ 'clang_fmt_revision': '99803d74e35962f63a775f29477882afd4d57d94',
# If you change this, also update the libc++ revision in
# //buildtools/deps_revisions.gni.
@@ -391,11 +396,6 @@
# GN CIPD package version.
'gn_version': 'git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3',
-
- # Also, if you change these, update buildtools/DEPS too.
- # TODO(crbug.com/1166332) rename to clang_format_revision.
- 'clang_fmt_revision': '99803d74e35962f63a775f29477882afd4d57d94',
-
}
# Only these hosts are allowed for dependencies in this DEPS file.
