Google Git
Sign in
chromium / chromium / src.git / 3c4c6b51590445e40e79ee7870d3dfe2d0937e89
commit3c4c6b51590445e40e79ee7870d3dfe2d0937e89[log] [tgz]
authorChristoph Schwering <[email protected]>Thu Nov 04 15:44:33 2021
committerChromium LUCI CQ <[email protected]>Thu Nov 04 15:44:33 2021
treed7752c90d5633aa9a5f2de38540c0e87ae83623e
parent2aa2862f036444f70d35e4fa611dabac2d488161 [diff]
[Autofill] Fixed AutofillManager memory leak. Added AutofillManager test.

AutofillManager builds a cache of FormStructures. It's not a cache
in the typical sense because it has no displacement strategy
whatsoever. Instead, its capacity is capped at 100. Once this limit is
reached, AutofillManager ignores any further forms.

This behaviour has two consequences:
1. AutofillManager leaks memory in the sense that it may store
   up to 100 forms that are not present in the DOM anymore.
2. After a website has added and removed 100 forms, AutofillManager
   effectively disables Autofill.

This CL fixes both issues by erasing forms which have been removed from
the DOM from AutofillManager's form cache. (AutofillManager is notified
about removed forms in OnFormsSeen(). This event is triggered, for
example, when a new field has been added to the DOM.)

This CL puts the fixes for the renderer- and the browser-memory leaks
behind the same Finch flag.

To this end, the CL renames the AutofillUseNewFormExtraction feature
to AutofillDisplaceRemovedForms and entirely removes the
AutofillUseOnlyFormRendererIDForOldDuplicateFormRemoval feature,
which was subsumed by AutofillUseNewFormExtraction.

This CL also creates a unit test for AutofillManager.

Bug: 1215337
Change-Id: I0e69f09dc834f32797146b5e79a087ce42acf881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226335
Reviewed-by: Matthias Körber <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#938278}
11 files changed
tree: d7752c90d5633aa9a5f2de38540c0e87ae83623e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.