Add flag to list all modes of external displays
This CL adds a flag that enables listing all display
modes in the display settings for external displays,
which can be very useful for debugging and development
purposes.
BUG=927848
TEST=Added tests, tested on device with 4k display
Change-Id: I748f2c2b645071723b94a37f759528b6437558aa
Reviewed-on: https://chromium-review.googlesource.com/c/1465682
Commit-Queue: Ahmed Fakhry <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634875}diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index c81a6854..3d30e2b 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -135,6 +135,7 @@
#include "ui/base/ui_base_features.h"
#include "ui/base/ui_base_switches.h"
#include "ui/compositor/compositor_switches.h"
+#include "ui/display/display_features.h"
#include "ui/display/display_switches.h"
#include "ui/events/blink/blink_features.h"
#include "ui/events/event_switches.h"
@@ -1503,6 +1504,9 @@
flag_descriptions::kVideoPlayerChromecastSupportDescription, kOsCrOS,
SINGLE_VALUE_TYPE(
chromeos::switches::kEnableVideoPlayerChromecastSupport)},
+ {"list-all-display-modes", flag_descriptions::kListAllDisplayModesName,
+ flag_descriptions::kListAllDisplayModesDescription, kOsCrOS,
+ FEATURE_VALUE_TYPE(display::features::kListAllDisplayModes)},
{"instant-tethering", flag_descriptions::kTetherName,
flag_descriptions::kTetherDescription, kOsCrOS,
FEATURE_VALUE_TYPE(chromeos::features::kInstantTethering)},
@@ -1542,7 +1546,7 @@
#if defined(OS_WIN)
{"enable-hdr", flag_descriptions::kEnableHDRName,
flag_descriptions::kEnableHDRDescription, kOsWin,
- FEATURE_VALUE_TYPE(features::kHighDynamicRange)},
+ FEATURE_VALUE_TYPE(display::features::kHighDynamicRange)},
#endif // OS_WIN
#if defined(OS_CHROMEOS)
{
@@ -2906,7 +2910,7 @@
#if defined(OS_CHROMEOS)
{"use-monitor-color-space", flag_descriptions::kUseMonitorColorSpaceName,
flag_descriptions::kUseMonitorColorSpaceDescription, kOsCrOS,
- FEATURE_VALUE_TYPE(features::kUseMonitorColorSpace)},
+ FEATURE_VALUE_TYPE(display::features::kUseMonitorColorSpace)},
{"quick-unlock-pin-signin", flag_descriptions::kQuickUnlockPinSignin,
flag_descriptions::kQuickUnlockPinSigninDescription, kOsCrOS,
