Google Git
Sign in
chromium / chromium / src.git / 1eea870b8ecd2123ccf364b04f1f09b50fccddb8
commit1eea870b8ecd2123ccf364b04f1f09b50fccddb8[log] [tgz]
authorspqchan <[email protected]>Fri Jun 08 06:13:36 2018
committerCommit Bot <[email protected]>Fri Jun 08 06:13:36 2018
treeb51b459047be52a5218a2ad49bef5a7ba8b7392a
parentc85e64e9f0b9258712c4a9bed5bfb70aa546d639 [diff]
Remove Cocoa Dependency from BrowserWindowTouchBar

To make the BrowserWindowTouchBar available to MacViews,
modify the class so that it no longer depends on Cocoa
code to receive updates for the touch bar item states.

This CL converts BookmarkTabHelperDelegate to
BookmarkTabHelperObserver so that BrowserWindowTouchBar
can observe the current web contents for starred changes.

Overview CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1086867

Bug: 841714
Change-Id: Id8944ad085d87288bcda767a53bb1abfe5c0eab9
Reviewed-on: https://chromium-review.googlesource.com/1090315
Commit-Queue: Sarah Chan <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#565570}
17 files changed
tree: b51b459047be52a5218a2ad49bef5a7ba8b7392a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .