Google Git
Sign in
chromium / chromium / src.git / 1782adb1a98dc011a10049787696bd70671c1d06
commit1782adb1a98dc011a10049787696bd70671c1d06[log] [tgz]
authorMark Mentovai <[email protected]>Wed Nov 08 05:11:27 2017
committerCommit Bot <[email protected]>Wed Nov 08 05:11:27 2017
tree20ba192661c3a0ac41aee52adc0cb2d7d16bbec2
parentd8540741f175eab5b502b5f3cf75ebefe837daab [diff]
Build all Crashpad tests in Chromium, and run on Chromium bots

Originally landed at efd8584f0232
(https://chromium-review.googlesource.com/751403) and subsequently
reverted at 49f5374a36de because of test failures. There are no changes
to this reland, but the test failures are addressed by updating Crashpad
to include
https://chromium.googlesource.com/crashpad/crashpad/+/d3b7463c7a48.

Until the recent ef647b4938a6 and 00a065492978, Crashpad tests did not
build or run in Chromium. Since then, crashpad_util_test was buildable
in Chromium, but was only run on Windows bots.

Crashpad has many more tests than crashpad_util_test, and its tests run
on both macOS and Windows. This change allows all of Crashpad’s unit
tests to build in Chromium’s GN-based build, and runs them on macOS and
Windows try- and buildbots.

Rather than having individual module-specific test executables like
crashpad_util_test, all unit tests are brought together into one
monolithic “crashpad_tests” executable.

On Windows, Crashpad also has an “end_to_end_test.py” which drives
crashpad_handler and some test crasher programs, and verifies the
produced minidump output by running the cdb debugger. That’s not
currently accounted for in the Chromium build.

As part of this change, additional Crashpad tools are also added to the
Chromium build, including the generate_dump tool.

Bug: 779790, 782011
Change-Id: Id192c40a1e7db178bdb093cd050b7fc5a5a876c9
Reviewed-on: https://chromium-review.googlesource.com/757188
Commit-Queue: Mark Mentovai <[email protected]>
Reviewed-by: Sigurður Ásgeirsson <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#514759}
18 files changed
tree: 20ba192661c3a0ac41aee52adc0cb2d7d16bbec2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .