commit | fdab33b3484cd6e1259015d0387a122cc62bf73f | [log] [tgz] |
---|---|---|
author | ktyliu <[email protected]> | Tue Jan 24 20:55:22 2017 |
committer | Commit bot <[email protected]> | Tue Jan 24 20:55:22 2017 |
tree | 5b8c598937dc76b227ba1e7ea5251702085065fd | |
parent | c6ddb615e307d10bff949570707cbaa964f5795d [diff] |
Reland "Fix RGBA alpha parsing and serialization to adhere to W3 standard." Using NeedsManualRebaseline since automatically rebaseline does not work Original description: Fix RGBA alpha parsing and serialization to adhere to W3 standard. Specifically, a 2.55 multiplication factor should be used, and serialization should be to two or three digits according to section <alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in https://w3c-test.org/cssom/serialize-values.html and also that the implementation is now same as Firefox as noted in the bug. Note a large number of tests need to be fixed, many of them because: - *-expected.txt specifically had bad alpha values such as 0.501961 or - an alpha value of 0.5 was previously 127 but should have been 128. The latter applies to the updated expected images too where the only difference was tiny bit of alpha (and rgb when alpha blended) change. BUG=453414 Review-Url: https://codereview.chromium.org/2626973005 Cr-Commit-Position: refs/heads/master@{#445802}