| commit | 18160d1a84859addfd8b6a6f354a65cb55395318 | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <[email protected]> | Tue Aug 04 16:09:22 2020 |
| committer | Commit Bot <[email protected]> | Tue Aug 04 16:09:22 2020 |
| tree | 4118deb3a6159d61aa557741d8a5938670a54042 | |
| parent | b2cd7834861521f9f5e88102701599d4db5bc123 [diff] |
DCHECK that a committing frame receives valid URLLoaderFactory bundle.
The primary goal of this CL, is being able to add the following DCHECKs:
DCHECK(loader_factories_);
DCHECK(loader_factories_->HasBoundDefaultFactory());
to RenderFrameImpl::DidCommitNavigation. If these DCHECKs hold, then
ChildURLLoaderFactoryBundle::GetFactory should always get the
|base_result| from the base class and therefore shouldn't ever need to
fall back ot the |direct_network_factory_| fallback (which wraps the
deprecated, process-wide / frame-agnostic factory).
One scenario where the new DCHECKs didn't hold before this CL is
RenderFrameImpl::LoadHTMLString which is mostly used from tests, but
also has a call in the product from
MimeHandlerViewContainerManager::LoadEmptyPage which is used by
MimeHandlerViewEmbedder::CheckSandboxFlags to load an empty page when
security checks fail. Another scenario is unit tests like
RenderViewImplTest going through TestRenderFrame (where tests drive the
simulated commit). All of these cases don't actually use the factory
bundle and therefore can just use the NotImplementedURLLoaderFactory.
The CL splits GetLoaderFactoryBundleFallback from
GetLoaderFactoryBundleFromCreator to make it more obvious when the
fallback is actually needed. In particular, this allows the new DCHECKs
in RenderFrameImpl::DidCommitNavigation to explicitly avoid the
fallback.
To facilitate reuse of NotImplementedURLLoaderFactory from
//content/renderer the CL moves this class from //content/test into
//services/network/public/cpp. The CL also adds NOTREACHED to
NotImplementedURLLoaderFactory::CreateLoaderAndStart to ensure that
future callers don't accidentally start using the factory.
NOTREACHED is also added to the non-opaque-origin/DwoC case in
ChildURLLoaderFactoryBundle::GetFactory (this probably should have been
part of r792963 which added a test that would have hit this NOTREACHED
before the fix).
Bug: 1098938, 1105794
Change-Id: Ifaedf40be35871b0a30797c09a236ea131b24447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321346
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#794566}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.