| commit | 19f70b6a0d53a9cce4aff3cb62fbaef8be3981d4 | [log] [tgz] |
|---|---|---|
| author | Devlin Cronin <[email protected]> | Sun Oct 01 04:14:05 2017 |
| committer | Commit Bot <[email protected]> | Sun Oct 01 04:14:05 2017 |
| tree | 63f5bbbed3d498403a2f86a489d17776605aa3ba | |
| parent | 95ecb913508e3dfc32afb93f6b930dc8d8514de9 [diff] |
[Extensions] Don't store ExternalInstallInfo in vectors of pointers ExternalInstallInfos are currently stored in std::vector<std::unique_ptr<T>>s, but they should just be stored in std::vector<T>s (where T is either ExternalInstallInfoFile or ExternalInstallInfoUpdateUrl). Once constructed, the vectors themselves are never passed, so the only time moves are necessary is during vector resizing, which for the number of external extensions users should be relatively rare. Additionally, the structs themselves are fairly cheap to move. Save on dynamic allocations and just store these in std::vectors. [email protected] for customization/customization_document_unittest.cc Bug: 770007 Change-Id: Ic3e3ea2de8ee09455fc021914eba20e1bdca2df0 Reviewed-on: https://chromium-review.googlesource.com/692975 Commit-Queue: Devlin <[email protected]> Reviewed-by: Karan Bhatia <[email protected]> Cr-Commit-Position: refs/heads/master@{#505501}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .