Switch SSLCertRequestInfo creations to MakeRefCounted
(Also get a net::HttpResponseHeader that I noticed along the way.)
Slowly trim away at all the bare news in the codebase.
Bug: none
Change-Id: Icb40949dbf2f7d4d7b1538d139e8f3b0d7d449f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684297
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Eric Roman <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#675265}
diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc
index 7c9e1d3..319e455c4 100644
--- a/net/http/bidirectional_stream_unittest.cc
+++ b/net/http/bidirectional_stream_unittest.cc
@@ -591,7 +591,7 @@
}
TEST_F(BidirectionalStreamTest, ClientAuthRequestIgnored) {
- scoped_refptr<SSLCertRequestInfo> cert_request(new SSLCertRequestInfo());
+ auto cert_request = base::MakeRefCounted<SSLCertRequestInfo>();
cert_request->host_and_port = host_port_pair_;
// First attempt receives client auth request.
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index b9cfb31c..4e86490 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -1060,7 +1060,7 @@
} else if (result == ERR_SSL_CLIENT_AUTH_CERT_NEEDED) {
DCHECK(stream_.get());
DCHECK(IsSecureRequest());
- response_.cert_request_info = new SSLCertRequestInfo;
+ response_.cert_request_info = base::MakeRefCounted<SSLCertRequestInfo>();
stream_->GetSSLCertRequestInfo(response_.cert_request_info.get());
result = HandleCertificateRequest(result);
if (result == OK)
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 388842c8..a5f7a90 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -15097,7 +15097,7 @@
request_info.traffic_annotation =
net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS);
- scoped_refptr<SSLCertRequestInfo> cert_request(new SSLCertRequestInfo());
+ auto cert_request = base::MakeRefCounted<SSLCertRequestInfo>();
cert_request->host_and_port = HostPortPair("www.example.com", 443);
// [ssl_]data1 contains the data for the first SSL handshake. When a
@@ -15202,7 +15202,7 @@
request_info.traffic_annotation =
net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS);
- scoped_refptr<SSLCertRequestInfo> cert_request(new SSLCertRequestInfo());
+ auto cert_request = base::MakeRefCounted<SSLCertRequestInfo>();
cert_request->host_and_port = HostPortPair("www.example.com", 443);
// When TLS False Start is used, SSLClientSocket::Connect() calls will
