Warn on Use of CComPtr
CComPtr has been deprecated in Chromium's codebase in favor of
Microsoft::WRL::ComPtr.
BUG=5027
Change-Id: I3918227f797ba1b5306cdd65a77f56a0a15bfdff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906249
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Auto-Submit: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#714284}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 2b5e1a07..9da44927 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1167,6 +1167,16 @@
r'^content/renderer/.*\.(cc|h)$',
),
),
+ (
+ 'CComPtr',
+ (
+ 'New code should use Microsoft::WRL::ComPtr from wrl/client.h as a ',
+ 'replacement for CComPtr from ATL. See http://crbug.com/5027 for more ',
+ 'details.'
+ ),
+ False,
+ (),
+ ),
)
# Format: Sequence of tuples containing:
