| commit | d2cf0a010075d9679711fff36ebdaa7369e6edd7 | [log] [tgz] |
|---|---|---|
| author | Jeremy Roman <[email protected]> | Mon Mar 23 23:49:34 2020 |
| committer | Commit Bot <[email protected]> | Mon Mar 23 23:49:34 2020 |
| tree | fee4b71d860f893d2677f4b0253ec41a526e1e54 | |
| parent | bb6352874877cbc4648e93397c21a7ce9836e8fc [diff] |
browser_theme_pack: Simplify GetPersistentIDBy*. Since https://codereview.chromium.org/1677303002, there is only one table that is ever searched, so we can unconditionally use that table and inline assumptions about it, like that the string is never actually null. The std::map is a premature optimization and is almost certainly now a pessimization in practice: linear scans of 16 entries are very cheap and as a bonus are thread-safe and easy to reason about. If better performance were needed, we could sort kPersistingImages by IDR but this too seems like a premature optimization as long as it remains relatively small. Change-Id: I0f9bbb2c6357b650903538235eb5f5112709c958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098850 Commit-Queue: Peter Kasting <[email protected]> Auto-Submit: Jeremy Roman <[email protected]> Reviewed-by: Peter Kasting <[email protected]> Cr-Commit-Position: refs/heads/master@{#752646}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.