Add MediaStoppedReason to WCO
Add MediaStoppedReason as an argument to MediaStoppedPlaying on
WebContentsObserver. This will contain information as to
whether the media was stopped because it reached the end.
It is needed for Media Engagement.
BUG=781726
Change-Id: I84eee732269cb6859d42ac5a5d34185bbd1d6e2d
Reviewed-on: https://chromium-review.googlesource.com/758583
Commit-Queue: Becca Hughes <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#516365}diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e51a993..713a920 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -5931,12 +5931,13 @@
void WebContentsImpl::MediaStoppedPlaying(
const WebContentsObserver::MediaPlayerInfo& media_info,
- const WebContentsObserver::MediaPlayerId& id) {
+ const WebContentsObserver::MediaPlayerId& id,
+ WebContentsObserver::MediaStoppedReason reason) {
if (media_info.has_video)
currently_playing_video_count_--;
for (auto& observer : observers_)
- observer.MediaStoppedPlaying(media_info, id);
+ observer.MediaStoppedPlaying(media_info, id, reason);
}
void WebContentsImpl::MediaResized(
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index edf88164..26c633a 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -841,7 +841,8 @@
const WebContentsObserver::MediaPlayerId& id);
void MediaStoppedPlaying(
const WebContentsObserver::MediaPlayerInfo& media_info,
- const WebContentsObserver::MediaPlayerId& id);
+ const WebContentsObserver::MediaPlayerId& id,
+ WebContentsObserver::MediaStoppedReason reason);
// This will be called before playback is started, check
// GetCurrentlyPlayingVideoCount if you need this when playback starts.
void MediaResized(const gfx::Size& size,
