Google Git
Sign in
chromium / chromium / src.git / 24632bb4e9d1d1a40fa34e3c62dd7ad87521fc46
commit24632bb4e9d1d1a40fa34e3c62dd7ad87521fc46[log] [tgz]
authorYutaka Hirano <[email protected]>Fri Mar 23 08:55:12 2018
committerCommit Bot <[email protected]>Fri Mar 23 08:55:12 2018
treed0bbbd8178a285247e277d9fa3f0d6dd9f703c66
parentb6a6ff2a26a89cfcaffb1081aa0eceebfe2a8a93 [diff]
Have WebSocket work with Network Service

This CL integrates WebSocket with the network service if it's enabled.
Before this CL, blink used WebSocket in content/browser even when
the network service is enabled. As a result, cookies were not shared
between the usual requests and WebSockets. This CL fixes the test
failures.

On the other hand, the WebSocket implementation living in
/services/network still lacks some functionalities, which results in
new test failures.

 - http/tests/security/cookies/websocket/third-party-cookie...
   I guess these failures share the same cause with
   http/tests/security/cookies/third-party... failures, and will be
   fixed altogether.
 - http/tests/websocket/multiple-connections-throttled.html
   This will be fixed the the throttling is implemented.
 - http/tests/devtools/websocket/websocket-handshake.js
   I don't know why this test fails. I will investigate.
 - Browser tests
   This is caused by the lack of WebRequest API support. I will work
   on it.

Bug: 721400
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8553be467e88f34929f5585376bdadd31b043e17
Reviewed-on: https://chromium-review.googlesource.com/964105
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Yuri Wiitala <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/master@{#545390}
15 files changed
tree: d0bbbd8178a285247e277d9fa3f0d6dd9f703c66
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .