| commit | 263e93e3e6ad65dc66abad514c3cf3e4c1010af8 | [log] [tgz] |
|---|---|---|
| author | James Cook <[email protected]> | Wed Nov 08 17:37:24 2017 |
| committer | Commit Bot <[email protected]> | Wed Nov 08 17:37:24 2017 |
| tree | 4fc01f8c25c915244dc98def45e3b5b04ff136ee | |
| parent | adf969a7cb9ee663fe7083f0f94faa05d81d2e0d [diff] |
Reland: cros: Replace shelf STATUS_ACTIVE with STATUS_RUNNING
This was reverted due to failures in mash_browser_tests for
ShelfBrowserTest.StatusBubble. The problem was actually
due to 9716183168af9fd41917aca3ce613b9801b670c3 and that CL has been
reverted.
> cros: Replace shelf STATUS_ACTIVE with STATUS_RUNNING
>
> Before the material design shelf we used to show light bars underneath
> the shelf icons for running apps. An app with an active window had a
> brighter bar. With the MD redesign we show dots and there is no
> difference between running and active. Tracking the active state
> complicates the go/mustash refactor, especially in tests.
>
> * Eliminate the active state, which simplifies both code and tests
> * Remove ShelfButton::STATE_ACTIVE and STATE_FOCUSED, neither of
> which are used anymore
> * Eliminate browser tests that existed mostly to track the active
> state
>
> Bug: 678687
> Test: ash_unittests, browser_tests
> Change-Id: I3dc1b045d44ea1ecc5a311afa4d877d0e908e35a
> Reviewed-on: https://chromium-review.googlesource.com/757169
> Reviewed-by: Tom Sepez <[email protected]>
> Reviewed-by: Michael Wasserman <[email protected]>
> Commit-Queue: James Cook <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#514623}
[email protected],[email protected],[email protected]
Bug: 678687
Reviewed-on: https://chromium-review.googlesource.com/757937
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#514685}
Change-Id: Ief70c56e406ed27394716ea0752d10530aefb1f5
Reviewed-on: https://chromium-review.googlesource.com/758800
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#514872}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .