Google Git
Sign in
chromium / chromium / src.git / 26c049d160bcbb6d21aa6daf16da76ff81f301f4
commit26c049d160bcbb6d21aa6daf16da76ff81f301f4[log] [tgz]
authorAndrew Xu <[email protected]>Thu Feb 07 20:04:30 2019
committerCommit Bot <[email protected]>Thu Feb 07 20:04:30 2019
tree0e9faf58424dbd4aa74f672c14ba12b694c78e5f
parent8ca1a4de4fd926050770f7b5c411de8c3acf493a [diff]
Hiding the drag handle of app list depending on MRU windows

Implement a new UI feature: hiding the drag handle of app list
in tablet mode if there is no activatable window. The main strategy
is listed as following:

(1) OnWindowDestroyed event should be listened to. Considering
about the situation that closing the browser window through shelf
while home launcher is visible. Hence we need to observe all windows
from MRU list in app list code, which is pretty much what
MruWindowTracker does. So the app list controller should observe
MruWindowTracker and hide/show the drag handle when a window is closed.

(2) When the gesture makes the app list show, the home launcher
gesture handler should notify the app list controller when animation
ends. The latter checks MRU window list then hides/shows the handle.

Test: ash_unittests
Bug: 923089
Change-Id: I9d9d60e705326cfe2ff90c59da2cccb18db87942
Reviewed-on: https://chromium-review.googlesource.com/c/1445111
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#630039}
13 files changed
tree: 0e9faf58424dbd4aa74f672c14ba12b694c78e5f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .