Rename [Blink|Web]TestController interfaces to better name
BlinkTestControl and WebTestControl names were originated
by the legacy IPC name. But, the meaning of between them is
ambiguous. So it may cause us a confusion. So, this CL
suggests to rename the interface name as below,
In .mojom files,
- Rename WebTestControl to WebTestRenderThread interface
- Rename BlinkTestControl to WebTestRenderFrame interface
- Rename WebTestClient to WebTestControlHost interface
- Rename BlinkTestDump to WebTestDump struct
In c++ files,
- Rename BlinkTestController class to WebTestControlHost class
- Rename BlinkTestResultPrinter class to WebTestResultPrinter class
Lastly, this CL moves BlinkTestControl, BlinkTestClient, and
BlinkTestDump mojo stuff from blink_test.mojom to web_test.mojom
after renaming. Then, this CL removes blink_test.mojom file and
all includes.
Bug: 866140, 1039247
Change-Id: I3c839dbb452a50a6c8287f93965417d9fa8659c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113393
Commit-Queue: Gyuyoung Kim <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#763640}
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 0990e10..c16fa5ee 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -5192,7 +5192,7 @@
const base::FilePath& plugin_path,
base::ProcessId plugin_pid) {
// TODO(nick): Eliminate the |plugin_pid| parameter, which can't be trusted,
- // and is only used by BlinkTestController.
+ // and is only used by WebTestControlHost.
for (auto& observer : observers_)
observer.PluginCrashed(plugin_path, plugin_pid);
}
