Disable presubmit for invalid defined check in ABSL code.
ABSL is trying to be -Wundef clean and sending a patch for these
macros seems overkill. They are used inside a __APPLE__ block with
this pattern:
#if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
#endif
Bug: None
Change-Id: I863d099dcc3a2588388afab24a61be89884b392b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612913
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#660995}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 04cc0a70..e4c7c0084 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -3636,8 +3636,9 @@
def _CheckForInvalidIfDefinedMacros(input_api, output_api):
"""Check all affected files for invalid "if defined" macros."""
bad_macros = []
+ skipped_paths = ['third_party/sqlite/', 'third_party/abseil-cpp/']
for f in input_api.AffectedFiles():
- if f.LocalPath().startswith('third_party/sqlite/'):
+ if any([f.LocalPath().startswith(path) for path in skipped_paths]):
continue
if f.LocalPath().endswith(('.h', '.c', '.cc', '.m', '.mm')):
bad_macros.extend(_CheckForInvalidIfDefinedMacrosInFile(input_api, f))
