Google Git
Sign in
chromium / chromium / src.git / 289477f6c6cfc2ca788955623aede8ed02c08012
commit289477f6c6cfc2ca788955623aede8ed02c08012[log] [tgz]
authorWez <[email protected]>Thu Aug 24 20:51:30 2017
committerCommit Bot <[email protected]>Thu Aug 24 20:51:30 2017
treee3c69e03297a360a049a139d1669bed30a393780
parent546bd7074d0a7b96e56d717047c41f3e98768f21 [diff]
Allow LOG_DCHECK to be configured via Feature in SyzyASAN builds.

This CL supports an experiment to enable DCHECKs in some Canary builds,
in order to gather data on broken DCHECK'd invariants, e.g. due to
faulty calling code or incorrect/over-zealous DCHECKing.

This CL changes the LOG_DCHECK LogSeverity to be switchable at run-
time in SyzyASAN builds with DCHECKs enabled, based on the setting of
a "DcheckIsFatal" Feature.

The Feature defaults to off, with an exception for death-test child
processes to allow death-tests to continue to work without modification.
This means that DCHECKs will be compiled-in and generate INFO level log
output, and can be switched via the command-line, or via Finch
experiment, to be made fatal.

Bug: 596231

Change-Id: I390aecdba40c8a8b396d6a4a03162ff071e9c3d5
Reviewed-on: https://chromium-review.googlesource.com/559809
Commit-Queue: Wez <[email protected]>
Reviewed-by: Sigurður Ásgeirsson <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Alexei Svitkine (very slow) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#497183}
4 files changed
tree: e3c69e03297a360a049a139d1669bed30a393780
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .