| commit | 28cf935c4bc087f628f7db3e617db9fee44cfbf9 | [log] [tgz] |
|---|---|---|
| author | Karandeep Bhatia <[email protected]> | Thu Mar 19 05:14:42 2020 |
| committer | Commit Bot <[email protected]> | Thu Mar 19 05:14:42 2020 |
| tree | 40bf8cee35c0571fa2845635852e83ce919f7a5e | |
| parent | f187a2f5f062712cf6984557d2e69bf5268e3112 [diff] |
DNR: Change where the static indexed ruleset is stored. Currently the single static indexed ruleset for an extension is stored at $extension_path/_metadata/generated_indexed_ruleset. Since we plan to support multiple static rulesets, we need to store multiple indexed rulesets. This CL changes the static indexed ruleset location to $extension_path/_metadata/generated_indexed_rulesets/_ruleset$ruleset_id. This helps us move the code away from the assumption of a single static ruleset. As a result of this existing extensions with a DNR ruleset will initially fail to load the DNR ruleset. However the re-indexing logic should step in and ensure the extension works seamlessly. A side-effect for these extensions is that the old indexed ruleset will remain on disk. However this is ok since the API is still on beta and doesn't have significant usage yet. Furthermore, we do periodically clean up extension folders after extension updates. BUG=754526 Change-Id: Id3bd6c1e25fde4ceb1a34f9f84c67bfa340790ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094626 Commit-Queue: Karan Bhatia <[email protected]> Reviewed-by: Devlin <[email protected]> Cr-Commit-Position: refs/heads/master@{#751607}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.