Add strip_binary() targets for all eu-strip processing.
This moves all the Linux eu-strip processing from installer.include to
separate BUILD targets, similar to the existing chrome binary processing
(i.e. strip_chrome_binary). This will help ensure more consistent
processing, and will allow the release builders to rely on explicit
build targets to provide that processing, rather than just as a
side-effect of Linux packaging.
BUG=1260176
Change-Id: Idae6b0b76029433d4a6b2781bb8a2d7e810f5484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307971
Auto-Submit: Michael Moss <[email protected]>
Commit-Queue: Dirk Pranke <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#946826}
diff --git a/chrome/installer/linux/BUILD.gn b/chrome/installer/linux/BUILD.gn
index 4d9054e..4ab8f6b6 100644
--- a/chrome/installer/linux/BUILD.gn
+++ b/chrome/installer/linux/BUILD.gn
@@ -178,11 +178,62 @@
strip_binary("strip_chrome_binary") {
binary_input = "$root_out_dir/chrome"
- symbol_output = "$root_out_dir/chrome.debug"
- stripped_binary_output = "$root_out_dir/chrome.stripped"
deps = [ "//chrome" ]
}
+strip_binary("strip_chrome_crashpad_handler") {
+ binary_input = "$root_out_dir/chrome_crashpad_handler"
+ deps = [ "//components/crash/core/app:chrome_crashpad_handler" ]
+}
+
+strip_binary("strip_chrome_sandbox") {
+ binary_input = "$root_out_dir/chrome_sandbox"
+ deps = [ "//sandbox/linux:chrome_sandbox" ]
+}
+
+strip_binary("strip_libEGL_shlib") {
+ binary_input = "$root_out_dir/libEGL.so"
+ deps = [ "//third_party/angle:libEGL" ]
+}
+
+strip_binary("strip_libGLESv2_shlib") {
+ binary_input = "$root_out_dir/libGLESv2.so"
+ deps = [ "//third_party/angle:libGLESv2" ]
+}
+
+strip_binary("strip_libvulkan_shlib") {
+ binary_input = "$root_out_dir/libvulkan.so.1"
+ deps = [ "//third_party/vulkan-deps/vulkan-loader/src:libvulkan" ]
+}
+
+strip_binary("strip_swiftshader_libEGL_shlib") {
+ binary_input = "$root_out_dir/swiftshader/libEGL.so"
+ deps = [ "//third_party/swiftshader/src/OpenGL/libEGL:swiftshader_libEGL" ]
+}
+
+strip_binary("strip_swiftshader_libGLESv2_shlib") {
+ binary_input = "$root_out_dir/swiftshader/libGLESv2.so"
+ deps =
+ [ "//third_party/swiftshader/src/OpenGL/libGLESv2:swiftshader_libGLESv2" ]
+}
+
+strip_binary("strip_libvk_swiftshader.shlib") {
+ binary_input = "$root_out_dir/libvk_swiftshader.so"
+ deps = [ "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan" ]
+}
+
+if (enable_nacl) {
+ strip_binary("strip_nacl_helper") {
+ binary_input = "$root_out_dir/nacl_helper"
+ deps = [ "//components/nacl/loader:nacl_helper" ]
+ }
+
+ strip_binary("strip_nacl_helper_bootstrap") {
+ binary_input = "$root_out_dir/nacl_helper_bootstrap"
+ deps = [ "//native_client/src/trusted/service_runtime/linux:bootstrap" ]
+ }
+}
+
# This target builds all "normal" Linux installers. You must set
# is_component_build=false before building this target.
group("linux") {
@@ -318,6 +369,8 @@
":deb_packaging_files",
":save_build_info",
":strip_chrome_binary",
+ ":strip_chrome_crashpad_handler",
+ ":strip_chrome_sandbox",
":theme_files",
"//chrome",
"//chrome:packed_resources",
@@ -327,6 +380,8 @@
]
if (enable_nacl) {
public_deps += [
+ ":strip_nacl_helper",
+ ":strip_nacl_helper_bootstrap",
"//components/nacl/loader:nacl_helper",
# These are data_deps of nacl_helper, but that is not enough,
@@ -340,15 +395,23 @@
}
if (use_egl) {
public_deps += [
+ ":strip_libEGL_shlib",
+ ":strip_libGLESv2_shlib",
"//third_party/angle:libEGL",
"//third_party/angle:libGLESv2",
]
if (angle_shared_libvulkan && !is_chromeos) {
- public_deps += [ "//third_party/vulkan-deps/vulkan-loader/src:libvulkan" ]
+ public_deps += [
+ ":strip_libvulkan_shlib",
+ "//third_party/vulkan-deps/vulkan-loader/src:libvulkan",
+ ]
}
}
if (enable_swiftshader) {
public_deps += [
+ ":strip_libvk_swiftshader.shlib",
+ ":strip_swiftshader_libEGL_shlib",
+ ":strip_swiftshader_libGLESv2_shlib",
":swiftshader_libs",
"//third_party/swiftshader/src/Vulkan:icd_file",
"//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
