Place inner frame scrollbars on the left side, if indicated by the frame-level
text direction.
CL overrides ScrollView::shouldPlaceVerticalScrollbarOnLeft() from FrameView in
order to determine if a Frame level scrollbar should be placed on the left.
Logic is simple: it obeys what ever is set to the body node, as it determines
the page text direction.
For now, it only covers inner frames, as main frame level scrollbar placement
logic should be dictated by the application/system (see crbug.com/249860).
Patch does not introduce new tests, but marks the existing affected tests as
NeedsManualRebaseline in order to get
results for all platforms from the bots, and perform rebaselines accordingly.
Once this is done, idea is to re-mark them as flaky.
Bug=250514
Review URL: https://codereview.chromium.org/150733002
git-svn-id: svn://svn.chromium.org/blink/trunk@169180 bbb929c8-8fbe-4397-9dbb-9b2b20218538
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations
index 292ff79c5..eff1fc1 100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -115,20 +115,30 @@
crbug.com/225184 fast/repaint/relayout-fixed-position-after-scale.html [ ImageOnlyFailure ]
# Pixel tests for RTL iframe scrollbar is erroneous. Cannot observe on actual browser.
-crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-absolute-overflow.html [ NeedsManualRebaseline ]
-crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ NeedsManualRebaseline ]
-crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-fixed-overflow.html [ NeedsManualRebaseline ]
-crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ NeedsManualRebaseline ]
-crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow.html [ NeedsManualRebaseline ]
-crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ NeedsManualRebaseline ]
-crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow.html [ NeedsManualRebaseline ]
-crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ NeedsManualRebaseline ]
-crbug.com/192172 [ Win Linux Android Debug ] compositing/rtl/rtl-iframe-absolute-overflow.html [ Failure Pass ]
-crbug.com/192172 [ Win Linux Android Debug ] virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow.html [ Failure Pass ]
-crbug.com/192172 [ Win Linux Android Debug ] compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure Pass ]
-crbug.com/192172 [ Win Linux Android Debug ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure Pass ]
-crbug.com/192172 [ Win Linux Android Debug ] compositing/rtl/rtl-iframe-fixed-overflow.html [ Failure Pass ]
-crbug.com/192172 [ Win Linux Android Debug ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow.html [ Failure Pass ]
+# Temporarily marking the flaky set below as NeedsManualRebaseline, so we can grab results
+# from the bots, rebaseline, and re-mark them out as flaky.
+#crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-absolute-overflow.html [ NeedsManualRebaseline ]
+#crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ NeedsManualRebaseline ]
+#crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-fixed-overflow.html [ NeedsManualRebaseline ]
+#crbug.com/338794 [ Mac ] compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ NeedsManualRebaseline ]
+#crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow.html [ NeedsManualRebaseline ]
+#crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ NeedsManualRebaseline ]
+#crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow.html [ NeedsManualRebaseline ]
+#crbug.com/338794 [ Mac ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ NeedsManualRebaseline ]
+#crbug.com/192172 [ Win Linux Android Debug ] compositing/rtl/rtl-iframe-absolute-overflow.html [ Failure Pass ]
+#crbug.com/192172 [ Win Linux Android Debug ] virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow.html [ Failure Pass ]
+#crbug.com/192172 [ Win Linux Android Debug ] compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure Pass ]
+#crbug.com/192172 [ Win Linux Android Debug ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ Failure Pass ]
+#crbug.com/192172 [ Win Linux Android Debug ] compositing/rtl/rtl-iframe-fixed-overflow.html [ Failure Pass ]
+#crbug.com/192172 [ Win Linux Android Debug ] virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow.html [ Failure Pass ]
+crbug.com/250514 compositing/rtl/rtl-iframe-absolute-overflow.html [ NeedsManualRebaseline ]
+crbug.com/250514 compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ NeedsManualRebaseline ]
+crbug.com/250514 compositing/rtl/rtl-iframe-fixed-overflow.html [ NeedsManualRebaseline ]
+crbug.com/250514 compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ NeedsManualRebaseline ]
+crbug.com/250514 virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow.html [ NeedsManualRebaseline ]
+crbug.com/250514 virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled.html [ NeedsManualRebaseline ]
+crbug.com/250514 virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow.html [ NeedsManualRebaseline ]
+crbug.com/250514 virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled.html [ NeedsManualRebaseline ]
crbug.com/239811 crbug.com/229113 http/tests/history/redirect-js-location-assign-0-seconds.html [ Failure Pass ]
