Run clang-tidy modernize-use-equals-{delete,default} on //chromeos
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
BUG=778959,778957
Change-Id: I483dd3cae9e02497462b741e95105a234a9bd862
Reviewed-on: https://chromium-review.googlesource.com/789720
Commit-Queue: Chris Watkins <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#519967}diff --git a/chromeos/network/network_connect_unittest.cc b/chromeos/network/network_connect_unittest.cc
index d6fb1f9..be242d7 100644
--- a/chromeos/network/network_connect_unittest.cc
+++ b/chromeos/network/network_connect_unittest.cc
@@ -44,8 +44,8 @@
class MockDelegate : public NetworkConnect::Delegate {
public:
- MockDelegate() {}
- ~MockDelegate() override {}
+ MockDelegate() = default;
+ ~MockDelegate() override = default;
MOCK_METHOD1(ShowNetworkConfigure, void(const std::string& network_id));
MOCK_METHOD1(ShowNetworkSettings, void(const std::string& network_id));
@@ -59,8 +59,8 @@
class FakeTetherDelegate : public NetworkConnectionHandler::TetherDelegate {
public:
- FakeTetherDelegate() {}
- ~FakeTetherDelegate() override {}
+ FakeTetherDelegate() = default;
+ ~FakeTetherDelegate() override = default;
std::string last_connected_tether_network_guid() {
return last_connected_tether_network_guid_;
@@ -87,8 +87,8 @@
class NetworkConnectTest : public testing::Test {
public:
- NetworkConnectTest() {}
- ~NetworkConnectTest() override {}
+ NetworkConnectTest() = default;
+ ~NetworkConnectTest() override = default;
void SetUp() override {
testing::Test::SetUp();
